#1693 PR review update - typos etc

data-model/src/main/scala/za/co/absa/enceladus/model/versionedModel/VersionedSummary.scala

@@ -17,4 +17,4 @@ package za.co.absa.enceladus.model.versionedModel
 
 case class VersionedSummary(_id: String, latestVersion: Int)
 
-case class VersionsList(_id: String, versions: Seq[Int])
+case class VersionList(_id: String, versions: Seq[Int])

rest-api/src/main/scala/za/co/absa/enceladus/rest_api/controllers/v3/VersionedModelControllerV3.scala

@@ -52,7 +52,7 @@ abstract class VersionedModelControllerV3[C <: VersionedModel with Product
 
   @GetMapping(Array("/{name}"))
   @ResponseStatus(HttpStatus.OK)
-  def getVersionsList(@PathVariable name: String): CompletableFuture[VersionsList] = {
+  def getVersionsList(@PathVariable name: String): CompletableFuture[VersionList] = {
     versionedModelService.getAllVersionsValues(name) map {
       case Some(entity) => entity
       case None => throw notFound()

rest-api/src/main/scala/za/co/absa/enceladus/rest_api/repositories/VersionedMongoRepository.scala

@@ -27,7 +27,7 @@ import org.mongodb.scala.model.Updates._
 import org.mongodb.scala.model._
 import org.mongodb.scala.result.UpdateResult
 import za.co.absa.enceladus.model.menas._
-import za.co.absa.enceladus.model.versionedModel.{VersionedModel, VersionedSummary, VersionsList}
+import za.co.absa.enceladus.model.versionedModel.{VersionedModel, VersionedSummary, VersionList}
 
 import scala.concurrent.Future
 import scala.reflect.ClassTag
@@ -92,13 +92,13 @@ abstract class VersionedMongoRepository[C <: VersionedModel](mongoDb: MongoDatab
     collection.aggregate[VersionedSummary](pipeline).headOption().map(_.map(_.latestVersion))
   }
 
-  def getAllVersionsValues(name: String): Future[Option[VersionsList]] = {
+  def getAllVersionsValues(name: String): Future[Option[VersionList]] = {
     val pipeline = Seq(
       filter(getNameFilter(name)),
       Aggregates.sort(Sorts.ascending("version")),
       Aggregates.group("$name", Accumulators.push("versions", "$version")) // all versions into single array
     )
-    collection.aggregate[VersionsList](pipeline).headOption().map(_.map(vlist => VersionsList("versions", vlist.versions)))
+    collection.aggregate[VersionList](pipeline).headOption().map(_.map(vlist => VersionList("versions", vlist.versions)))
   }
 
   def getAllVersions(name: String, inclDisabled: Boolean = false): Future[Seq[C]] = {

rest-api/src/main/scala/za/co/absa/enceladus/rest_api/services/DatasetService.scala

@@ -94,14 +94,14 @@ class DatasetService @Autowired()(datasetMongoRepository: DatasetMongoRepository
   }
 
   override def getUsedIn(name: String, version: Option[Int]): Future[UsedIn] = {
-    val existingEntityF = version match {
+    val existingEntity = version match {
       case Some(version) => getVersion(name, version)
       case None          => getLatestVersion(name)
     }
 
-    existingEntityF.flatMap {
+    existingEntity.flatMap {
       case Some(_) => Future.successful(UsedIn()) // empty usedIn for existing datasets
-      case None => Future.failed(NotFoundException(s"Dataset '$name' in version ${version.getOrElse("any")}' nof found"))
+      case None => Future.failed(NotFoundException(s"Dataset '$name' in version ${version.getOrElse("any")}' not found"))
     }
   }
 

rest-api/src/main/scala/za/co/absa/enceladus/rest_api/services/VersionedModelService.scala

@@ -21,7 +21,7 @@ import org.springframework.security.core.context.SecurityContextHolder
 import org.springframework.security.core.userdetails.UserDetails
 import za.co.absa.enceladus.model.{ModelVersion, Schema, UsedIn, Validation}
 import za.co.absa.enceladus.model.menas._
-import za.co.absa.enceladus.model.versionedModel.{VersionedModel, VersionedSummary, VersionsList}
+import za.co.absa.enceladus.model.versionedModel.{VersionedModel, VersionedSummary, VersionList}
 import za.co.absa.enceladus.rest_api.exceptions._
 import za.co.absa.enceladus.rest_api.repositories.VersionedMongoRepository
 import za.co.absa.enceladus.model.menas.audit._
@@ -57,7 +57,7 @@ abstract class VersionedModelService[C <: VersionedModel with Product with Audit
     versionedMongoRepository.getAllVersions(name)
   }
 
-  def getAllVersionsValues(name: String): Future[Option[VersionsList]] = {
+  def getAllVersionsValues(name: String): Future[Option[VersionList]] = {
     versionedMongoRepository.getAllVersionsValues(name)
   }
 

rest-api/src/main/scala/za/co/absa/enceladus/rest_api/utils/implicits/package.scala

@@ -60,7 +60,7 @@ package object implicits {
     classOf[Run], classOf[Schema], classOf[SchemaField], classOf[SplineReference], classOf[RunSummary],
     classOf[RunDatasetNameGroupedSummary], classOf[RunDatasetVersionGroupedSummary],
     classOf[RuntimeConfig], classOf[OozieSchedule], classOf[OozieScheduleInstance], classOf[ScheduleTiming], classOf[DataFormat],
-    classOf[UserInfo], classOf[VersionedSummary], classOf[VersionsList], classOf[MenasAttachment], classOf[MenasReference],
+    classOf[UserInfo], classOf[VersionedSummary], classOf[VersionList], classOf[MenasAttachment], classOf[MenasReference],
     classOf[PropertyDefinition], classOf[PropertyType], classOf[Essentiality],
     classOf[LandingPageInformation], classOf[TodaysRunsStatistics],
     classOf[DataFrameFilter]

rest-api/src/test/scala/za/co/absa/enceladus/rest_api/integration/controllers/v3/DatasetControllerV3IntegrationSuite.scala

@@ -28,7 +28,7 @@ import za.co.absa.enceladus.model.dataFrameFilter._
 import za.co.absa.enceladus.model.properties.essentiality.Essentiality
 import za.co.absa.enceladus.model.properties.propertyType.EnumPropertyType
 import za.co.absa.enceladus.model.test.factories.{DatasetFactory, PropertyDefinitionFactory, SchemaFactory}
-import za.co.absa.enceladus.model.versionedModel.VersionsList
+import za.co.absa.enceladus.model.versionedModel.VersionList
 import za.co.absa.enceladus.model.{Dataset, UsedIn, Validation}
 import za.co.absa.enceladus.rest_api.integration.controllers.{BaseRestApiTestV3, toExpected}
 import za.co.absa.enceladus.rest_api.integration.fixtures._
@@ -129,9 +129,9 @@ class DatasetControllerV3IntegrationSuite extends BaseRestApiTestV3 with BeforeA
           parent = Some(DatasetFactory.toParent(datasetV1)))
         datasetFixture.add(datasetV1, datasetV2)
 
-        val response = sendGet[VersionsList](s"$apiUrl/datasetA")
+        val response = sendGet[VersionList](s"$apiUrl/datasetA")
         assertOk(response)
-        assert(response.getBody == VersionsList("versions", Seq(1, 2)))
+        assert(response.getBody == VersionList("versions", Seq(1, 2)))
       }
     }