Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change groupId of project to za.co.absa.enceladus #1090

Closed
GeorgiChochov opened this issue Dec 4, 2019 · 1 comment
Closed

Change groupId of project to za.co.absa.enceladus #1090

GeorgiChochov opened this issue Dec 4, 2019 · 1 comment
Assignees
@GeorgiChochov
Labels
Conformance Conformance Job affected Menas Menas component affected priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Standardization Standardization Job affected
Milestone
2.0.0

Comments

@GeorgiChochov
Copy link
Collaborator

Background

Currently, the project's groupId is the general organization za.co.absa and each module has a prefix enceladus-. This floods the maven central organization page and makes it harder to find just the enceladus modules. Spline and Cobirx, for example, avoid this by having the groupId as za.co.absa.spline and za.co.absa.cobrix to group the modules into the same space in maven.

Feature

We should change the groupId of the project to za.co.absa.enceladus to make this consistent with our other projects and to group the modules correctly in maven.
@GeorgiChochov GeorgiChochov added Conformance Conformance Job affected Menas Menas component affected priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Standardization Standardization Job affected labels Dec 4, 2019
@GeorgiChochov GeorgiChochov added this to the 2.0.0 milestone Dec 4, 2019
@GeorgiChochov GeorgiChochov self-assigned this Dec 4, 2019
GeorgiChochov added a commit that referenced this issue Dec 5, 2019
@GeorgiChochov
#1090 Change groupId to za.co.absa.enceladus
ed3fe99
GeorgiChochov added a commit that referenced this issue Dec 5, 2019
@GeorgiChochov
#1090 Rename dataModel module to data-model
416d5da
GeorgiChochov added a commit that referenced this issue Dec 5, 2019
@GeorgiChochov
#1090 Rename fixedWidth to fixed-width
eb203a6
GeorgiChochov added a commit that referenced this issue Dec 17, 2019
@GeorgiChochov
#1090 Change groupId to za.co.absa.enceladus
c3c44fa
GeorgiChochov added a commit that referenced this issue Dec 17, 2019
@GeorgiChochov
#1090 Rename dataModel module to data-model
4df83f3
GeorgiChochov added a commit that referenced this issue Dec 17, 2019
@GeorgiChochov
#1090 Rename fixedWidth to fixed-width
8156229
GeorgiChochov added a commit that referenced this issue Dec 17, 2019
@GeorgiChochov @yruslan
#1090 Rename fixed width module
9b5ca09 
Co-Authored-By: Ruslan Yushchenko <yruslan@gmail.com>
GeorgiChochov added a commit that referenced this issue Dec 18, 2019
@GeorgiChochov
#1090 Change groupId to za.co.absa.enceladus
23c0428
@GeorgiChochov
Copy link
Collaborator Author

Release notes
BREAKING All Enceladus modules are now under the same enceladus group ID in the absa.co.za organization. They will no longer have the enceldus- prefix and will not appear as top-level artifacts in maven.

yruslan pushed a commit that referenced this issue Jan 13, 2020
@GeorgiChochov @yruslan
#1090 Change groupId to za.co.absa.enceladus
8d99e4f
benedeki pushed a commit that referenced this issue Feb 4, 2020
@GeorgiChochov @benedeki
#1090 Change groupId to za.co.absa.enceladus
72c0142
benedeki pushed a commit that referenced this issue Mar 20, 2020
@GeorgiChochov @benedeki
#1090 Change groupId to za.co.absa.enceladus
228eb4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgiChochov GeorgiChochov

Labels
Conformance Conformance Job affected Menas Menas component affected priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Standardization Standardization Job affected
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@GeorgiChochov