Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract most/all logic from DynamicConformanceJob #1232

Closed
benedeki opened this issue Mar 17, 2020 · 1 comment · Fixed by #1377
Closed

Extract most/all logic from DynamicConformanceJob #1232

benedeki opened this issue Mar 17, 2020 · 1 comment · Fixed by #1377
Assignees
@AdrianOlosutean
Labels
Conformance Conformance Job affected feature New feature priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code

Comments

@benedeki
Copy link
Collaborator

Background

DynamicConformanceJob contains the main function but also a lot of surrounding processing that is hard to test

Feature

Move the application logic in DynamicConformanceJob into dedicated classes, for easier testing and to share common code with Standardization.
@benedeki benedeki added refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code feature New feature Conformance Conformance Job affected priority: medium Important but not urgent labels Mar 17, 2020
@benedeki benedeki mentioned this issue Jun 1, 2020
Closed
@AdrianOlosutean AdrianOlosutean mentioned this issue Jun 8, 2020
Merged
@AdrianOlosutean AdrianOlosutean self-assigned this Jun 11, 2020
@AdrianOlosutean
Copy link
Contributor

Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianOlosutean AdrianOlosutean

Labels
Conformance Conformance Job affected feature New feature priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1015 Refactoring Conformance and Standardization AbsaOSS/enceladus
2 participants
@AdrianOlosutean @benedeki