Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve helper scripts to run custom JARs #1400

Closed
yruslan opened this issue Jun 15, 2020 · 2 comments · Fixed by #1445
Closed

Improve helper scripts to run custom JARs #1400

yruslan opened this issue Jun 15, 2020 · 2 comments · Fixed by #1445
Assignees
Labels
feature New feature priority: medium Important but not urgent

Comments

@yruslan
Copy link
Contributor

yruslan commented Jun 15, 2020

Background

Currently, the JAR corresponding to Standardization and Conformance jobs is configured in enceladus_env.sh. For development and testing it would be very useful to override the location of the JAR so that SNAPSHOT versions be easier to test.

Feature

Check an environment variable SPARK_JOSB_JAR (the name is deliberately very short) in helper scripts. If it is defined, use the specified JAR instead of ones defined in enceladus_env.sh.

The workflow of a dev will be like this:

  1. Scp a snapshot jar to the user's home folder.
  2. Login to the env.
  3. Run export SPARK_JOBS_JAR=/path/to/jars/in/the/home/folder/spark-jobs.jar
  4. Run run_standardization.sh or run_conformance.sh as usual. The custom JAR will be used.
@yruslan
Copy link
Contributor Author

yruslan commented Jul 17, 2020

So people have pointed out that we have '--jar' option that does what is needed.
Maybe I forgot about it when wrote this issue 😛 , or maybe the '--jar' option was in parallel issue.

Nevertheless, an environment variable that overrides the jar might still be useful since sometimes we don't have access to the command line. For instance, if the job is run from customized scripts.

AdrianOlosutean pushed a commit that referenced this issue Jul 17, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 23, 2020
@AdrianOlosutean
Copy link
Contributor

Release notes:
Added ability to specify the jar as an environment variable using SPARK_JOBS_JAR_OVERRIDE in helper scripts

AdrianOlosutean added a commit that referenced this issue Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature priority: medium Important but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants