Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1422 and 1423 Remove HDFS and Oozie from Menas #1428

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

Zejnilovic
Copy link
Contributor

Removing HDFS and Oozie from Menas, dao and data-model

All this is for the containerization and moving Menas to cloud

Closes #1422
Closes #1423

lokm01
lokm01 previously approved these changes Jul 2, 2020
Copy link
Collaborator

@lokm01 lokm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the changes, looks ok from my perspective.

@@ -15,9 +15,9 @@

package za.co.absa.enceladus.model.menas

case class HDFSFolder
case class HDFSFolder2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why HDFSFolder2? Shouldn't it be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

AdrianOlosutean
AdrianOlosutean previously approved these changes Jul 2, 2020
Copy link
Contributor

@AdrianOlosutean AdrianOlosutean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me now

Copy link
Collaborator

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing the project version in the main pom to make the build recognizable from regular branch?

@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Zejnilovic
Copy link
Contributor Author

What about changing the project version in the main pom to make the build recognizable from regular branch?

Smart. Added AWS qualifier. Adheres to semver.

@Zejnilovic Zejnilovic merged commit 18cb47f into aws-poc Jul 2, 2020
@Zejnilovic Zejnilovic deleted the feature/1422-remove-hdfs-from-menas branch July 2, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants