-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1422 and 1423 Remove HDFS and Oozie from Menas #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed the changes, looks ok from my perspective.
@@ -15,9 +15,9 @@ | |||
|
|||
package za.co.absa.enceladus.model.menas | |||
|
|||
case class HDFSFolder | |||
case class HDFSFolder2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why HDFSFolder2? Shouldn't it be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing the project version in the main pom to make the build recognizable from regular branch?
data-model/src/main/scala/za/co/absa/enceladus/model/menas/HDFSFolder.scala
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Smart. Added AWS qualifier. Adheres to semver. |
Removing HDFS and Oozie from Menas, dao and data-model
All this is for the containerization and moving Menas to cloud
Closes #1422
Closes #1423