Feature/1416 S3 input/output for Enceladus on EMR (S2.4, H2.8.5) #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all directly-hdfs touching stuff disabled (atum, performance measurements, info files, output path checking)
# Add menasfargate into hosts
sudo nano /etc/hosts
# paste
20.0.63.69 menasfargate
# save & exit (ctrl+O, ctrl+X)
# Running standardization works via:
spark-submit --class za.co.absa.enceladus.standardization.StandardizationJob --conf "spark.driver.extraJavaOptions=-Dmenas.rest.uri=http://menasfargate:8080 -Dstandardized.hdfs.path=s3://euw1-ctodatadev-dev-bigdatarnd-s3-poc/enceladusPoc/ao-hdfs-data/stdOutput/standardized-{0}-{1}-{2}-{3}" ~/enceladusPoc/spark-jobs-2.11.0-SNAPSHOT.jar --menas-credentials-file ~/enceladusPoc/menas-credentials.properties --dataset-name dk_test1_emr285 --raw-format json --dataset-version 1 --report-date 2019-11-27 --report-version 1 2> ~/enceladusPoc/stderr.txt
…ut, s3 conf output)
0- all directly-hdfs touching stuff disabled (atum, performance measurements, info files, output path checking)
# Add menasfargate into hosts
sudo nano /etc/hosts
# paste
20.0.63.69 menasfargate
# save & exit (ctrl+O, ctrl+X)
# Running conformance works via:
spark-submit --class za.co.absa.enceladus.conformance.DynamicConformanceJob --conf "spark.driver.extraJavaOptions=-Dmenas.rest.uri=http://menasfargate:8080 -Dstandardized.hdfs.path=s3://euw1-ctodatadev-dev-bigdatarnd-s3-poc/enceladusPoc/ao-hdfs-data/stdOutput/standardized-{0}-{1}-{2}-{3}" ~/enceladusPoc/spark-jobs-2.11.0-SNAPSHOT.jar --menas-credentials-file ~/enceladusPoc/menas-credentials.properties --dataset-name dk_test1_emr285 --dataset-version 1 --report-date 2019-11-27 --report-version 1 2> ~/enceladusPoc/conf-log.txt
dk1844
force-pushed
the
feature/1416-aws-emr-poc
branch
from
da8d4b8
to
67e4012
Compare
dk1844
commented
Aug 13, 2020
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>bom</artifactId> | ||
| <version>${aws.java.sdk.version}</version> |
There was a problem hiding this comment.
Note that the SDK is not being used, yet as of now, but the support is now added because the usage is expected based on the S3 PoC.
AdrianOlosutean
previously approved these changes
Aug 13, 2020
|
|
||
| // TODO fix for s3 [ref issue #1416] | ||
| //withPartCols.writeInfoFile(preparationResult.pathCfg.publishPath) | ||
| //writePerformanceMetrics(preparationResult.performance, cmd) | ||
|
|
||
| if (conformanceReader.isAutocleanStdFolderEnabled()) { |
There was a problem hiding this comment.
I think this should also be commented out
Zejnilovic
reviewed
Aug 17, 2020
| case Some(p) => p | ||
| } | ||
| // TODO fix for s3 [ref issue #1416] | ||
| val recordCount = 100 |
There was a problem hiding this comment.
-1 would be better if there is no check for it to be > 0. Because 100 seems like a valid value.
There was a problem hiding this comment.
Thanks, took your advice (=> -1; #1416 (comment))
Zejnilovic
previously approved these changes
Aug 17, 2020
dk1844
requested review from
benedeki,
DzMakatun,
HuvarVer and
lokm01
as code owners
dk1844
dismissed stale reviews from Zejnilovic and AdrianOlosutean
via
85570d7
lokm01
previously approved these changes
Aug 17, 2020
|
Whats the menas loadbalanced IP for? Can we use the internal ELB hostname instead? |
Your question is spot on, so I replaced it with the internal ELB hostname as suggested. The IP would work, too, but should be a more durable solution, I agree. |
% Conflicts: % pom.xml
|
Kudos, SonarCloud Quality Gate passed!
|
lokm01
approved these changes
Aug 24, 2020
AdrianOlosutean
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PoC allows to run Enceladus using s3, there are following preconditions:
(This is a more durable way than defining the in
/etc/hostsas e.g.20.0.62.173 menas-load-balanced)Also, a couple of things have been disabled (commented out) in order for Enceladus not to fail on HDFS attempting to use paths starting with
s3://:Standardization
To run standardization
Conformance
To run conformance
Test-run output
The standardization & conformance run successfully outputs the data onto s3: