Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feautre/1733 lineage dumper - 2nd edition #1766

Merged
merged 6 commits into from
May 25, 2021

Conversation

dk1844
Copy link
Contributor

@dk1844 dk1844 commented Apr 23, 2021

This PR should effectively replace #1742 - new cherry-picked on develop-ver3.0 basis without any spline-0.4-6 integration baggage.

Using a 0.6.0-SNAPSHOT spline agent from AbsaOSS/spline-spark-agent.

Test run

  • needs compatible develop-ver3.0 means on AWS to run
export MENAS_URL="https://some.menas.on.aws"
export SPLINE_URL="https://some.spline.0.6+.backend/producer"

spark-submit --class za.co.absa.enceladus.standardization.StandardizationJob \
--conf "spark.driver.extraJavaOptions=-Dmenas.rest.uri=$MENAS_URL -Dstandardized.hdfs.path=s3://my-example-bucket123/superhero2/std/standardized-{0}-{1}-{2}-{3} -Dspline.producer.url=$SPLINE_URL -Dspline.lineageDispatcher=composite -Dspline.lineageDispatcher.composite.dispatchers=http,hdfs " \
~/enceladus/spark-jobs-3.0.0-SNAPSHOT.jar \
--menas-credentials-file ~/enceladus/svc-aws-credentials.properties \
--dataset-name SuperheroesS3 --dataset-version 1 --report-date 2020-08-06 --report-version 1 \
--raw-format csv --header true 
$ aws --profile saml s3 ls --recursive s3://my-example-bucket123/superhero2/std
2021-04-23 14:35:48       2225 superhero2/std/standardized-SuperheroesS3-1-2020-08-06-1/_INFO
2021-04-23 14:35:43     127725 superhero2/std/standardized-SuperheroesS3-1-2020-08-06-1/_LINEAGE
2021-04-23 14:35:35          0 superhero2/std/standardized-SuperheroesS3-1-2020-08-06-1/_SUCCESS
2021-04-23 14:35:35      45229 superhero2/std/standardized-SuperheroesS3-1-2020-08-06-1/part-00000-c16c8a6d-84b3-46bd-8a
51-f86f2ea14071-c000.snappy.parquet

(values of MENAS_URL and SPLINE_URL; and my-example-bucket123 are not actual values used)

  • testran again @ 2021-05-25, reconfirmed to work - _LINEAGE file is present on S3.

Closes #1733.

RN suggestion

  • Spline agent 0.6.0 integrated - support for _LINEAGE file generation is present

@AdrianOlosutean
Copy link
Contributor

Point/base this PR to develop-ver3.0?

@dk1844 dk1844 changed the base branch from develop to develop-ver-3.0 April 23, 2021 08:52
pom.xml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dk1844 dk1844 marked this pull request as ready for review May 24, 2021 14:48
Copy link
Contributor

@AdrianOlosutean AdrianOlosutean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good(didn't get to test though)

@dk1844 dk1844 added the PR:tested Only for PR - PR was tested by a tester (person) label May 25, 2021
@dk1844 dk1844 merged commit 70999f5 into develop-ver-3.0 May 25, 2021
@dk1844 dk1844 deleted the feautre/1733-lineage-dumper2 branch May 25, 2021 06:44
@dk1844 dk1844 linked an issue May 25, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:tested Only for PR - PR was tested by a tester (person)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spline _LINEAGE dumper to work on S3
2 participants