#417 Spark-XML hack removed #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XMLHack removed, the test holds.
dk1844
requested review from
AdrianOlosutean,
benedeki,
DzMakatun,
HuvarVer and
lokm01
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
dk1844
added
the
PR:no testing needed
|
After discussion with @benedeki and @Zejnilovic, I have assigned label no testing needed as the added test case and its way of originating should suffice as evidence of correct behavior, guarding from regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###RN suggestion
XML input standardization: SparkXML-hack for arrays removed, no change in function should be noticed.
Closes #417