Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1882 Update Cobrix to v.2.4.1 #1883

Merged
merged 6 commits into from
Oct 15, 2021
Merged

#1882 Update Cobrix to v.2.4.1 #1883

merged 6 commits into from
Oct 15, 2021

Conversation

yruslan
Copy link
Contributor

@yruslan yruslan commented Aug 18, 2021

Closes #1882

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

benedeki
benedeki previously approved these changes Aug 21, 2021
View reviewed changes
Copy link
Collaborator

@benedeki benedeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and change seems simple enough.
Would be nice to check with some Cobol file

@yruslan yruslan changed the title #1882 Update Cobrix to v.2.3.0 #1882 Update Cobrix to v.2.4.1 Sep 22, 2021
benedeki
benedeki previously approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@benedeki benedeki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read the code. Will run a E2E sanity test.

@yruslan
Copy link
Contributor Author

yruslan commented Oct 5, 2021

Please, let me know if can do anything else to the PR. Maybe to make PR labels pass

AdrianOlosutean
AdrianOlosutean approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@AdrianOlosutean AdrianOlosutean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on the cluster, LGTM

@AdrianOlosutean AdrianOlosutean added the PR:tested Only for PR - PR was tested by a tester (person) label Oct 14, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
54.5% 54.5% Duplication

@yruslan yruslan merged commit 74247a8 into develop Oct 15, 2021
@yruslan yruslan deleted the feature/1882-update-cobrix-to-2-3-0 branch October 15, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianOlosutean AdrianOlosutean AdrianOlosutean approved these changes

@benedeki benedeki benedeki left review comments

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@DzMakatun DzMakatun Awaiting requested review from DzMakatun

@HuvarVer HuvarVer Awaiting requested review from HuvarVer

@lokm01 lokm01 Awaiting requested review from lokm01

Assignees
No one assigned
Labels
PR:tested Only for PR - PR was tested by a tester (person)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Cobrix 2.3.0
3 participants
@yruslan @AdrianOlosutean @benedeki