Merge/release 2.24 into develop ver 3 #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1873) * 1868 statistics with missing counts and datasets missing proprties
* 1843 Home page with properties, side panel with missing counts and summary page for properties with tab containing datasets missing that particular property
* #1603 serde tests for CR and MT DataFrameFilters (mongo-bson-based serde tests for CR and MT DataFrameFilters, mongo-bson-based serde tests extended for CR with a blank mappingTableFilter)
Project config and management updates * poc issue template * CODEOWNERS update * developers update * Badges to README.md
1881 HyperConformance enceladus_info_version from payload
#1887 defaultTimestampTimeZone can be source type specific * `DefaultsByFormat` extends the `Defaults` trait, being able to read defaults from configuration files * `DefaultsByFormat` offers further granularity by first checking the format specific setting only then taking the global one * Basic `GlobalDefaults` are not configuration dependent anymore * Standardization now user `DefaultsByFormat` for its defaults, where rawFormat is used for format parameter * Switched to configuration path to be `enceladus.defaultTimestampTimeZone.default` and `enceladus.defaultTimestampTimeZone.[rawFormat]` respectively * `defaultTimestampTimeZone` is still supported/read as an obsolete fallback Co-authored-by: Daniel K <dk1844@gmail.com>
* Upgrade of Atum to 3.6.0 * Writing the default time zones for timestamps and dates into _INFO file
…into-develop-ver-3 # Conflicts: # dao/pom.xml # data-model/pom.xml # examples/pom.xml # menas/pom.xml # migrations-cli/pom.xml # migrations/pom.xml # plugins-api/pom.xml # plugins-builtin/pom.xml # pom.xml # rest-api/src/main/scala/za/co/absa/enceladus/rest_api/controllers/LandingPageController.scala # rest-api/src/main/scala/za/co/absa/enceladus/rest_api/controllers/StatisticsController.scala # rest-api/src/main/scala/za/co/absa/enceladus/rest_api/services/DatasetService.scala # rest-api/src/main/scala/za/co/absa/enceladus/rest_api/services/PropertyDefinitionService.scala # rest-api/src/main/scala/za/co/absa/enceladus/rest_api/services/StatisticsService.scala # rest-api/src/main/scala/za/co/absa/enceladus/rest_api/utils/implicits/package.scala # rest-api/src/test/scala/za/co/absa/enceladus/rest_api/integration/controllers/DatasetApiIntegrationSuite.scala # rest-api/src/test/scala/za/co/absa/enceladus/rest_api/integration/repositories/DatasetRepositoryIntegrationSuite.scala # rest-api/src/test/scala/za/co/absa/enceladus/rest_api/integration/repositories/StatisticsIntegrationSuite.scala # spark-jobs/pom.xml # spark-jobs/src/main/resources/spline.properties.template # spark-jobs/src/main/scala/za/co/absa/enceladus/conformance/ConformanceExecution.scala # spark-jobs/src/main/scala/za/co/absa/enceladus/standardization/StandardizationExecution.scala # spark-jobs/src/main/scala/za/co/absa/enceladus/standardization/interpreter/StandardizationInterpreter.scala # spark-jobs/src/test/scala/za/co/absa/enceladus/conformance/interpreter/InterpreterSuite.scala # spark-jobs/src/test/scala/za/co/absa/enceladus/standardization/StandardizationExecutionSuite.scala # utils/pom.xml
AdrianOlosutean
requested review from
benedeki,
dk1844,
DzMakatun,
HuvarVer and
lokm01
as code owners
AdrianOlosutean
force-pushed
the
merge/release-2.24-into-develop-ver-3
branch
from
444072a to
58d247e
Compare
dk1844
previously approved these changes
Sep 29, 2021
There was a problem hiding this comment.
LGTM (just read the code), but so did the previous versions of release 2.24 -> develop-ver-3. So what changed that it now works?
dk1844
reviewed
Sep 30, 2021
| @@ -263,7 +290,6 @@ class DatasetApiIntegrationSuite extends BaseRestApiTest with BeforeAndAfterAll | |||
|
|
|||
| assert(headers2.getFirst("Location").contains("/api/dataset/dataset/2")) | |||
| assert(body2.version == 2) | |||
| assert(body2.properties == expectedPropertiesSet) | |||
There was a problem hiding this comment.
Ahaaa, this is most probably the key change that "made it work" 😸
There was a problem hiding this comment.
OK let's merge it this way and finally merge. Just please add a // TODO DatasetApiIntegrationSuite failing test on merge to Enceladus 3 #1949
|
Kudos, SonarCloud Quality Gate passed!
|
benedeki
approved these changes
Oct 21, 2021
benedeki
added
the
PR:no testing needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.