Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2027: Ensures TimezoneNormalizer is used in tests #2030

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

benedeki
Copy link
Collaborator

  • New class TZNormalizedSparkTestBase used over all tests instead of SparkTestBase

Closes #2027

* New class `TZNormalizedSparkTestBase` used over all tests instead of `SparkTestBase`
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AdrianOlosutean
Copy link
Contributor

Do you want this PR to wait for spark-commons 0.3.0?

@benedeki
Copy link
Collaborator Author

benedeki commented Mar 14, 2022

Do you want this PR to wait for spark-commons 0.3.0?

Not really. It works now. The 0.3.0 would just add more flexibility.

Copy link
Contributor

@AdrianOlosutean AdrianOlosutean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally and passes

@AdrianOlosutean AdrianOlosutean added the PR:tested Only for PR - PR was tested by a tester (person) label Mar 15, 2022
@benedeki benedeki merged commit a10e6b5 into develop-ver-3.0 Mar 15, 2022
@benedeki benedeki deleted the bugfix/2027-missing-timezone-normalizer branch March 15, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:tested Only for PR - PR was tested by a tester (person)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants