#480 Basic search for versioned menas entities #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokm01
added
refactoring
lokm01
requested review from
yruslan,
DzMakatun,
benedeki,
Zejnilovic and
GeorgiChochov
1 cannot read property typeGetting new console error when searching and no data is found
|
2 Suggestions don't auto refreshIf I create a new schema/dataset/mapping table and I don't do a full refresh I don't see the newly created item in the suggestions. 3 Suggestion suggest disabled itemsSuggestions suggest something that was already deleted/disabled |
GeorgiChochov
requested changes
Jun 17, 2019
menas/src/main/scala/za/co/absa/enceladus/menas/repositories/VersionedMongoRepository.scala
Show resolved
Hide resolved
menas/src/main/scala/za/co/absa/enceladus/menas/repositories/VersionedMongoRepository.scala
Outdated
Show resolved
Hide resolved
Any chance this is related to lastpass/lastpass-cli#428 ?? |
Signed-off-by: Jan Scherbaum <kmoj02@gmail.com>
Signed-off-by: Jan Scherbaum <kmoj02@gmail.com>
4 Errors on start-up in private modeI open a private mode. Go to Menas's login page and this is what shows. 1 Cannot read property typeIn private mode, I see no such error. You were probably correct. 5 Suggestions don't show at allCurrently. No suggestions show up for me. But partial names work fine. |
GeorgiChochov
requested changes
Jun 18, 2019
| } | ||
| } | ||
| "return seq of versioned summaries matching the search query" when { | ||
| "datasets exist and search query is provided" in { |
There was a problem hiding this comment.
Can we break this down into separate cases? A test case should really only test one case (very limited asserts).
- test case for searching a disabled entity, should be in the "return an empty Seq" cases
- full match (given several datasets with similar names, i.e. search("dataset1"), returns "dataset1" of "dataset1,dataset2,dataset,somethingelse")
- partial match (given several datasets with similar names, i.e search("dataset") returns "dataset1,dataset2,dataset" of "dataset1,dataset2,dataset,somethingelse")
- empty search (search("") returns all enabled datasets)
| } | ||
| "return distinct list of enabled names" when { | ||
| "datasets exist" in { | ||
| val dataset1 = DatasetFactory.getDummyDataset(name = "dataset1", version = 1, |
There was a problem hiding this comment.
Same as for DatasetMongoRepository::getLatestVersions
- This should fix the undefined error on load - This should also fix the updated suggestions on edits etc
|
Ok this last commit should fix 2) 4) 5) |
Zejnilovic
approved these changes
Jun 18, 2019
DzMakatun
approved these changes
Jun 18, 2019
Signed-off-by: Jan Scherbaum <kmoj02@gmail.com>
feature/480-basic-search-for-versioned-entities Conflicts: menas/src/main/scala/za/co/absa/enceladus/menas/repositories/VersionedMongoRepository.scala menas/src/test/scala/za/co/absa/enceladus/menas/integration/repositories/DatasetRepositoryIntegrationSuite.scala
GeorgiChochov
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.