Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpLineageDispatcher: support for OAuth #600

Closed
wajda opened this issue Feb 14, 2023 · 1 comment · Fixed by #644
Closed

HttpLineageDispatcher: support for OAuth #600

wajda opened this issue Feb 14, 2023 · 1 comment · Fixed by #644
Assignees
@wajda
Labels
feature
Milestone
1.1.0

Comments

@wajda
Copy link
Contributor

wajda commented Feb 14, 2023

comes out of discussion #513

https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow

Think about generic declarative approach.
@wajda wajda added the feature label Feb 14, 2023
@wajda wajda added this to the 1.1.0 milestone Feb 14, 2023
@wajda
Copy link
Contributor Author

wajda commented Mar 28, 2023

The first working version has been implemented in PR #631.

Suggested improvements:

  1. Make the authentication implementation configurable through the config in a generic way.
  2. (Optionally) Make it reusable in the different dispatchers
  3. Remove "mode: enabled" and replace it with the presence/absence of the "authentication" property.

@wajda wajda self-assigned this Mar 28, 2023
wajda added a commit that referenced this issue Apr 1, 2023
@wajda
issue #600 yaml files formatting
9ed92e5
wajda added a commit that referenced this issue Apr 1, 2023
@wajda
issue #600 introduce property "authentication.type"
c715444
wajda added a commit that referenced this issue Apr 1, 2023
@wajda
issue #600 introduce property "authentication.type"
a234ef1
wajda added a commit that referenced this issue Apr 1, 2023
@wajda
issue #600 introduce property "authentication.type"
70697d0
@wajda wajda mentioned this issue Apr 1, 2023
Merged
wajda added a commit that referenced this issue Apr 1, 2023
@wajda
issue #600 + copyright
ea9602b
@wajda wajda closed this as completed in #644 Apr 1, 2023
wajda added a commit that referenced this issue Apr 1, 2023
@wajda
Feature/spline spark agent 600 authentication type (#644)
054bb68 
* issue #600 yaml files formatting

* issue #600 introduce property "authentication.type"

* issue #600 + copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
feature
Projects
Spline
Status: Done
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Feature/spline spark agent 600 authentication type AbsaOSS/spline-spark-agent
1 participant
@wajda