Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/spline spark agent 714 classpath collision #715

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

wajda
Copy link
Contributor

@wajda wajda commented Jun 28, 2023

fixes #714

Relocated:

  • za.co.absa.commons:commons
  • io.github.classgraph:glassgraph
  • com.fasterxml.uuid:java-uuid-generator
  • org.scalaj:scalaj-http
  • com.lihaoyi:fastparse

Moved from the root module to the integration-tests module:

  • com.github.bigwheel:util-backports

@wajda wajda changed the base branch from develop to release/1.2 June 28, 2023 18:23
@wajda wajda requested a review from cerveada June 28, 2023 18:27
@wajda wajda marked this pull request as ready for review June 28, 2023 22:21
core/pom.xml Outdated Show resolved Hide resolved
@cerveada
Copy link
Contributor

Does this break tests when running from IDE?

…ir custom Spline extensions. Return `absa-shaded-jackson` po the core pom for clarity. Add comment to the shade plugin config in the root pom.
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wajda
Copy link
Contributor Author

wajda commented Jun 29, 2023

Does this break tests when running from IDE?

No, in root pom, there is only a shade plugin config, but it's only executed in bundles.
I added the comment for clarity.

@wajda wajda merged commit ead3233 into release/1.2 Jun 29, 2023
2 of 3 checks passed
@wajda wajda deleted the bugfix/spline-spark-agent-714-classpath-collision branch June 29, 2023 11:51
wajda added a commit that referenced this pull request Aug 1, 2023
…ntally shaded in the bundle. Partially revert commit ead3233 (#715). 'za.com.absa.commons' package must not be relocated.
wajda added a commit that referenced this pull request Aug 1, 2023
…ntally shaded in the bundle. Partially revert commit ead3233 (#715). 'za.com.absa.commons' package must not be relocated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classpath collision on ABSA Commons
2 participants