Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odpstable-fix-#820 #828

Merged
merged 3 commits into from
Sep 5, 2024
Merged

odpstable-fix-#820 #828

merged 3 commits into from
Sep 5, 2024

Conversation

BerlinJava
Copy link
Contributor

@BerlinJava BerlinJava commented Sep 2, 2024 •
edited by wajda
Loading

fixes #820

Add a case for maxcompute table

@wajda
Copy link
Contributor

wajda commented Sep 3, 2024

Thank you @BerlinJava! Could you add some integration tests to this please?

@BerlinJava
Copy link
Contributor Author

I made this change for odps table and it works well in our company where I work for, beside, as I known that Maxcompute of AliCloud related repositories are not open sources, I can not get more information from their repo， so may I know how to do that integration test ? thx

1 similar comment
@BerlinJava
Copy link
Contributor Author

I made this change for odps table and it works well in our company where I work for, beside, as I known that Maxcompute of AliCloud related repositories are not open sources, I can not get more information from their repo， so may I know how to do that integration test ? thx

wajda
wajda previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@wajda wajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK, if the source code is closed, and since the change is almost trivial I guess we can skip tests in this case. LGTM.

@wajda wajda requested a review from cerveada September 3, 2024 22:16
cerveada
cerveada previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@cerveada cerveada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BerlinJava BerlinJava dismissed stale reviews from cerveada and wajda via 846f41f September 5, 2024 03:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BerlinJava
Copy link
Contributor Author

please help to approve again, if any query please let me know

@wajda wajda merged commit 1a910c2 into AbsaOSS:develop Sep 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wajda wajda wajda left review comments

@cerveada cerveada cerveada left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spline doesn't support MaxCompute table storage?
3 participants
@BerlinJava @wajda @cerveada