Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit variant to execute and query fns #196

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Aug 21, 2023

This PR aims at allowing projects to use unit variants in the ExecuteMsg and QueryMsg and still be able to use ExecuteFns and QueryFns.
An example usage is using cw-orch with Polytone : https://github.com/DA0-DA0/polytone/blob/a94feae54ee20cb51d8533d79229296e52164859/contracts/main/note/src/msg.rs#L59

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2c15da3
Status:⚡️  Build in progress...

View logs

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #196 (0cafc1c) into main (8c1d78e) will decrease coverage by 0.2%.
Report is 20 commits behind head on main.
The diff coverage is 87.9%.

❗ Current head 0cafc1c differs from pull request most recent head 2c15da3. Consider uploading reports for the commit 2c15da3 to get more accurate results

Files Changed Coverage Δ
contracts/mock_contract_u64/src/lib.rs 48.9% <6.6%> (-19.6%) ⬇️
contracts/mock_contract/src/lib.rs 94.0% <92.8%> (-0.7%) ⬇️
packages/cw-orch-fns-derive/src/execute_fns.rs 99.1% <100.0%> (+2.6%) ⬆️
packages/cw-orch-fns-derive/src/query_fns.rs 100.0% <100.0%> (+2.3%) ⬆️

... and 9 files with indirect coverage changes

Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, few small nits

contracts/mock_contract/src/lib.rs Show resolved Hide resolved
contracts/mock_contract/src/lib.rs Outdated Show resolved Hide resolved
contracts/mock_contract_u64/src/lib.rs Outdated Show resolved Hide resolved
packages/cw-orch-fns-derive/src/execute_fns.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, anything blocks it from opening pr?

@Kayanski Kayanski marked this pull request as ready for review August 23, 2023 15:36
@CyberHoward
Copy link
Contributor

I'll leave merges on this repo to you @Kayanski from now on :)

@Kayanski Kayanski merged commit 75b0d71 into main Aug 24, 2023
14 of 15 checks passed
@Kayanski Kayanski deleted the fix/add-execute-fns branch August 24, 2023 10:19
Kayanski added a commit that referenced this pull request Sep 5, 2023
Added Unit and Unnamed variants to execute and query fns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants