-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First impl of Mock and MockBech32 #325
Conversation
Deploying with Cloudflare Pages
|
Codecov ReportAttention:
Additional details and impacted files
|
Did a bit of a refactor of the queries to make them API generic by relying on the difference in addr generation between the mock and bech32 impls. I'm a bit confused by the |
Haha gotta love the refactor hack :) --> Yes we can split the 2 impls in separate files, sure ! The differences are very subtle :) |
Another question we should ask ourselves is if we want to keep supporting |
See answer above? I think that it's really good to simplify the users life in case no bech32 verification is needed |
This PR aims at introducing MockBech32 that enforces valid addresses
Tests needs a little revamp (doc tests mostly), but that's a good looking implementation and usable by users.