Removed feature interface from docs #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to keep the re-export though here ! Without the feature flag macro |
Deploying cw-orchestrator with
|
| Latest commit: |
4d40257
|
| Status: | ⚡️ Build in progress... |
|
I'm pretty sure there are more instances where this flag is used (in the actual code which is referenced in the documentation). Maybe something that @Kayanski could remove more efficiently |
Buckram123
approved these changes
Mar 27, 2024
| cargo add --optional cw-orch | ||
| cargo add cw-orch |
docs/src/quick_start.md
Outdated
| cw-orch = {version = "0.17.0", optional = true } # Latest version at time of writing | ||
| cw-orch = {version = "0.21.0" } # Latest version at time of writing |
There was a problem hiding this comment.
Love it from looking at every change in these docs
CyberHoward
reviewed
Mar 28, 2024
|
|
||
| ## Importing cw-orch | ||
|
|
||
| Importing `cw-orch` as a dependency in your smart contract is not a problem. We have built this library such that every feature that cw-orch imports, uses or exposes is not included when compiled for Wasm. This means that you are safe to use any cw-orch feature when developing your application, creating interfaces, exporting features, because none of it will land in your contract. |
There was a problem hiding this comment.
Suggested change
| Importing `cw-orch` as a dependency in your smart contract is not a problem. We have built this library such that every feature that cw-orch imports, uses or exposes is not included when compiled for Wasm. This means that you are safe to use any cw-orch feature when developing your application, creating interfaces, exporting features, because none of it will land in your contract. | |
| Importing `cw-orch` as a dependency in your smart contract is not a problem. We have built this library such that every feature that cw-orch imports, uses or exports not included when compiled for Wasm. This means that you are safe to use any cw-orch feature when developing your application, creating interfaces, exporting features, because none of it will land in your contract. |
CyberHoward
reviewed
Mar 28, 2024
CyberHoward
reviewed
Mar 28, 2024
| {{#include ../../../contracts/counter/src/interface.rs:uploadable_impl}} | ||
| ``` | ||
|
|
||
| ### Entry Points |
There was a problem hiding this comment.
I think this is the only location where we call them entry points?
CyberHoward
approved these changes
Mar 28, 2024
Co-authored-by: CyberHoward <88450409+CyberHoward@users.noreply.github.com>
Kayanski
deleted the
ani/orc-87-update-documentation-to-reflect-removed-requirement-of
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at updating the cw-orch docs: