Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollkit #353

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Rollkit #353

merged 7 commits into from
Apr 3, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Mar 27, 2024

This PR aims at integrating rollkit inside cw-orch.

For this integration, I used :

I modified :

  • In init.sh script, I replaced all occurences of stake by uwasm to be able to pay for gas with the created mnemonic/address
  • I used the generated genesis mnemonic of wasmd as LOCAL_MNEMONIC

Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9563db
Status: ✅  Deploy successful!
Preview URL: https://fa38e850.cw-orchestrator.pages.dev
Branch Preview URL: https://rollkit.cw-orchestrator.pages.dev

View logs

@CyberHoward
Copy link
Contributor

I modified :

  • In init.sh script, I replaced all occurences of stake by uwasm to be able to pay for gas with the created mnemonic/address
  • I used the generated genesis mnemonic of wasmd as LOCAL_MNEMONIC
    Were these modifications upstreamed?

@Kayanski
Copy link
Contributor Author

Kayanski commented Apr 2, 2024

I modified :

  • In init.sh script, I replaced all occurences of stake by uwasm to be able to pay for gas with the created mnemonic/address
  • I used the generated genesis mnemonic of wasmd as LOCAL_MNEMONIC
    Were these modifications upstreamed?

Not sure what you're saying here. The init.sh oart yes, the local mnemonic part is something the user should do

@CyberHoward
Copy link
Contributor

Then that should prefably be documented as well in the doc that you added (how to get the local mnemonic if following the tutorial)

@adairrr adairrr requested a review from CyberHoward April 2, 2024 20:38
@adairrr
Copy link
Contributor

adairrr commented Apr 2, 2024

Is ROLLKIT_1 going to be the best name for this network configuration given that it's always run locally?

Should we include details on connecting to a hosted rollup?

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.7%. Comparing base (b8ceade) to head (f9563db).
Report is 2 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
packages/cw-orch-networks/src/networks/mod.rs 0.0% <ø> (ø)

... and 1 file with indirect coverage changes

@CyberHoward
Copy link
Contributor

Is ROLLKIT_1 going to be the best name for this network configuration given that it's always run locally?

Should we include details on connecting to a hosted rollup?

Our documentation should follow their documentation imo. Otherwise we need to document too much overlapping stuff and if they are not following the rollkit docs then they probably know what they are doing and they can figure out stuff themselves, like a hosted rollup.

@Kayanski Kayanski merged commit bc991e4 into main Apr 3, 2024
18 of 20 checks passed
@Kayanski Kayanski deleted the rollkit branch April 3, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants