generate new Sender if hd_index was provided in set_options
#404
Conversation
Buckram123
changed the title
Sender if hd_index was provided in set_options
Deploying cw-orchestrator with
|
| Latest commit: |
9215edd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ecec2f8a.cw-orchestrator.pages.dev |
| Branch Preview URL: | https://misha-orc-127-daemon-rebuild.cw-orchestrator.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
| .build() | ||
| .unwrap(); | ||
|
|
||
| let indexed_daemon = daemon.rebuild().hd_index(56).build().unwrap(); |
There was a problem hiding this comment.
Changing the hd_index doesn't change the sender address?
There was a problem hiding this comment.
On rebuild - yes, that's what this PR tries to fix
There was a problem hiding this comment.
Then why are you asserting that the address basically remains the same? This test confuses me a bit
There was a problem hiding this comment.
assert_ne is not equal, before this PR they eq, and now they ne
What do you mean by this? |
Here, when the state of the daemon is updated (grpc channel for instance, if a same daemon is used for another chain), the sender channel is not updated which leads to issues if you're changing the chain. This is addressed in #326 |
Kayanski
deleted the
misha/orc-127-daemon-rebuild-hd_index-does-not-generate-new-key
branch
hd_index impacts private key meaning if it's provided inside
SenderOptionsnew Sender should be created from scratchCloses ORC-127, Closes ORC-125