Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polytone dep #501

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Remove polytone dep #501

merged 2 commits into from
Sep 30, 2024

Conversation

Buckram123
Copy link
Contributor

We only use 1 type from polytone but it comes with all cosmwasm v1 packages, we should temporary replace it

Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 531e216
Status: ✅  Deploy successful!
Preview URL: https://71df2a5d.cw-orchestrator.pages.dev
Branch Preview URL: https://buckram-remove-polytone.cw-orchestrator.pages.dev

View logs

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.9%. Comparing base (776a34a) to head (531e216).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...kages/interchain/interchain-core/src/ack_parser.rs 33.3% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...kages/interchain/interchain-core/src/ack_parser.rs 21.3% <33.3%> (+0.5%) ⬆️

Copy link
Contributor

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very good idea ! If this removes cosmwasm-std 1 all-together, LGTM

@Buckram123
Copy link
Contributor Author

Yes, very good idea ! If this removes cosmwasm-std 1 all-together, LGTM

Let's merge it with #500 and see

@Kayanski Kayanski merged commit a58d5af into main Sep 30, 2024
12 of 15 checks passed
@Kayanski Kayanski deleted the buckram/remove-polytone branch September 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants