Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bank send function #526

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kayanski
Copy link
Contributor

This PR aims at adding the bank send function on cwEnv directly using the TxHandler trait.
This function is mandatory for blockchain operations and shouldn't need to belong to another trait.

Checklist

  • Changelog updated.
  • Docs updated.

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1eeceb8
Status:🚫  Build failed.

View logs

Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Are we sure about removing instead of deprecating BankModule trait on cw-orch-interchain?

packages/cw-orch-core/src/environment/tx_handler.rs Outdated Show resolved Hide resolved
Co-authored-by: Mykhailo Donchenko <91957742+Buckram123@users.noreply.github.com>
@Kayanski
Copy link
Contributor Author

Nice! Are we sure about removing instead of deprecating BankModule trait on cw-orch-interchain?

This was only a test trait, so yeah sure about that

…funds-on-the-account' of github.com:AbstractSDK/cw-orchestrator into nicolas/abs-569-create-a-deposit-helper-for-depositing-funds-on-the-account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants