Skip to content
This repository has been archived by the owner on Nov 18, 2018. It is now read-only.

Update MFRC522 Library #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MFRC522 Library #17

wants to merge 1 commit into from

Conversation

xrobau
Copy link

@xrobau xrobau commented Sep 3, 2017

As per the comment in https://gbatemp.net/threads/tools-amiibomb.467990/page-27#post-7516237 I updated the MFRC522 library. Seems to work fine.

@xrobau
Copy link
Author

xrobau commented Sep 3, 2017

However, after viewing the diff, it appears to be missing the 'Magic' section of code here - Does this need to be re-added?

(Note I didn't try writing)

@peacepenguin
Copy link

the magic section was moved to a new file in the upstream library: MFRC522hack.h being that it is for "hackable" cards that aren't within the spec, so the library was moved to a "hackable" library that also doesn't follow the spec.

Since amiibomb doesn't currently use any of the MAGIC functions for resetting UID cards, its fine to leave out for now, at some point if/when the "reset hackable cards" feature is added to amiibomb then the MFRC522hack library can be added then.

I've built successfully with the updated lib, and without the hack.h file.

I don't think the MFRC522debug library should be included though, IMO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants