Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redundant PYIMATH_EXPORTS causing compile issues on Windows Clang #330

Conversation

ZTKlein
Copy link
Contributor

@ZTKlein ZTKlein commented Jun 30, 2023

Compilation of the python bindings fails using Clang on Windows, due to declared __declspec(import)'s on code without external linkage. The behavior in MSVC is to throw these declarations away, but Clang will error out. It doesn't cause issues to remove them, as they don't serve a functional purpose -- the changed lines are in an anonymous namespace in PyImathStringTable.cpp and on deleted functions in PyImathUtil.h. Currently the PyImathTestC and PyImathTest_Python3 tests fail in my environment, though that's unrelated to the changes in this PR.

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@ZTKlein
Copy link
Contributor Author

ZTKlein commented Jun 30, 2023

Closing because I didn't have my git config set properly for the commit. Will open a new one in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant