Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LamaGeneralizedSchlick and LamaIridescence Nodes #1897

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

mkuo-lucasfilm
Copy link
Contributor

  1. Added a LamaGeneralizedSchlick node to MaterialX (Renderman definition: https://rmanwiki.pixar.com/display/REN26/LamaGeneralizedSchlick)

  2. Added a LamaIridescence node to MaterialX (Renderman definition: https://rmanwiki.pixar.com/display/REN26/LamaIridescence)

1. Added a LamaGeneralizedSchlick  node to MaterialX (Renderman definition: https://rmanwiki.pixar.com/display/REN26/LamaGeneralizedSchlick)

2. Added a LamaIridescence node to MaterialX (Renderman definition: https://rmanwiki.pixar.com/display/REN26/LamaIridescence)
Adjusted input values for LamaIridescence
Fixed formatting of doc strings for LamaGeneralizedSchlick and LamaIridescence
@mkuo-lucasfilm
Copy link
Contributor Author

LamaGeneralizedSchlick Render
generalizedschlick

@mkuo-lucasfilm
Copy link
Contributor Author

LamaIridescence Render
iridescence

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @mkuo-lucasfilm!

@jstone-lucasfilm jstone-lucasfilm merged commit 328fde8 into AcademySoftwareFoundation:main Jun 24, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants