Fix include install - compatible with cmake 3.16 #1928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this build together, @ld-kerley, and after further discussion on the MaterialX Slack, it sounds like our best approach is to move forward with the upgrade to CMake 3.24 in #1929. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1923 - that lifted the minimum cmake version 3.23 - but using
FILE_SET.This PR should provide the same install functionality, but compatible with cmake 3.16 - albeit with more cmake code complexity.
Ultimately I think it would be nice to move the cmake version up to 3.23, but if we're not able to do that now, then this is an alternate path forwards.