Move proposed Specification changes to separate Proposals doc #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new MaterialX Proposals document. Remove duplicated description of and/or/not in Math nodes section of main spec. Add TOC links for Kronos PBR and OpenPBR shading examples.
Updated proposals doc to address feedback, added mention of it in the README
Nodes and elements and other things that were moved into the Proposals doc are here removed from the Specification doc.
jstone-lucasfilm
changed the title
ld-kerley
reviewed
Aug 2, 2024
jstone-lucasfilm
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
This looks great to me, @dbsmythe, and I think it's worthwhile to move forward with this improvement!
jstone-lucasfilm
merged commit e98d05f
into
AcademySoftwareFoundation:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes, Elements and other things that were described in the MaterialX Specification but which have not actully been implemented yet are now moved out of tyhe Spec docs and into a separate MaterialX Proposals document.
Also adds table-of-content links in the PBR Spec for Khronos glTF PBR and OpenPBR Surface shading model examples, and removes duplicate descriptions of the Logical "and", "or" and "not" operators.