Additional improvements to MaterialX Lama nodes #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkuo-lucasfilm
commented
Jul 30, 2024
•
mkuo-lucasfilm
commented
- Updated LamaGeneralizedSchlick implementation (changed the transmission component from a dielectric BSDF to a generalized schlick BSDF, adjusted implementation of reflectionTint)
- Updated LamaSSS and LamaTranslucent (removed LobeName and matte inputs as they are renderer-specific)
- Updated default values and help documentation of MaterialX Lama nodes to be consistent with Renderman Lama nodes.
Updating Lama Nodes to be consistent with the default values and help documentation of RenderMan nodes
mkuo-lucasfilm
changed the title
Removing LobeName and matte inputs from LamaSSS and LamaTranslucent, as they are renderer-specific
Removing sssID input, as its documented functionality is closely related to the renderer-specific concept of lobe names
ahostettler
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Thank you @mkuo-lucasfilm for updating the Lama definitions. There are still some smaller discrepancies that would be good to address, otherwise it looks good.
1. Switched order of Fresnel mode switch 2. Fixed default values for Lama test documents 3. LamaGeneralizedSchlick - implementation of transmission component, roughness calculation 4. LamaIridescence - reintroduced anisotropy direction and rotation
|
LamaGeneralizedSchlick Renders with default transmissionTint, cyan transmissionTint, and red TransmissionTint |
ahostettler
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Thank you @mkuo-lucasfilm. There is still one small issue, otherwise it looks good.
Switching input of transmission color0 to fresnel_mode_switch
jstone-lucasfilm
approved these changes
Aug 7, 2024
jstone-lucasfilm
merged commit 67702da
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.