-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type description improvements #2176
base: main
Are you sure you want to change the base?
Type description improvements #2176
Conversation
This PR includes and replaces #2107, which can be closed if this PR is approved. |
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
/// Optionally pass in an externally created TypeSystem here, | ||
/// if you want to keep type descriptions alive after the lifetime | ||
/// of the shader generator. | ||
EsslShaderGenerator(TypeSystemPtr typeSystem = TypeSystem::create()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niklasharrysson @ld-kerley Since we're encouraging developers to use the associated create
function for each ShaderGenerator subclass, I would recommend omitting default arguments for our ShaderGenerator constructors, leaving only the default arguments on our ShaderGenerator create
functions. This would simplify the code a bit, and would help to clarify which entry point developers are expected to use.
Does that sound like a reasonable simplification to you both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I’ll make that change 👍
This change list is an overhaul of the type system in shader generation.
Improvements include:
Co-work with @ld-kerley