Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking when building fully shared with the dependencies also build as shared libraries #1958

Closed

Conversation

irieger
Copy link

@irieger irieger commented Mar 19, 2024

I'd suggest to fix the linking to ensure OpenColorIO can be build with its own requirements build as shared libraries. Currently it will throw linker errors when linking all the included CLI tools.

For more details, also see: conan-io/conan-center-index#23112

Up to now the conan recipe didn't run with dynamic linking as there was a blocker in the configuration to link minizip-ng dynamically. When I tried to fix it locally, I came up with this change. Otherwise it can also be done by fixing the linking of all the tools to include the requirements manually.

Copy link

CLA Not Signed

@remia
Copy link
Collaborator

remia commented May 27, 2024

Linking the related Conan issue for reference: conan-io/conan-center-index#23421, this seems to be a ld specific issue according to this comment.

@irieger
Copy link
Author

irieger commented Jun 4, 2024

Linking the related Conan issue for reference: conan-io/conan-center-index#23421, this seems to be a ld specific issue according to this comment.

Sorry, forgot to update here. Good to have it linkes here but maybe it is a non-issue here and we just close it? As it isn't OCIO specific as it happens for other things too, but depends on the linker it might be more a linker/build infra problem then. Or would you object closing?

@doug-walker doug-walker added the Build Issue Issues related to build or environment problems on any platform. label Jun 4, 2024
@remia
Copy link
Collaborator

remia commented Jun 5, 2024

Yes I'll close this then, I think the issue is more likely to be with Conan, in the event anything needs to be changed in OCIO CMake scripts, we can obviously open a new PR.

@remia remia closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issue Issues related to build or environment problems on any platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants