-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Actions CI support #991
Add GH Actions CI support #991
Conversation
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Here is the successful full GH Actions build for reference, since it will not trigger in this PR: |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
GH Actions build status: https://github.com/michdolan/OpenColorIO/runs/610888635?check_suite_focus=true |
I am now going to test a full build again by temporarily enabling the scheduled jobs. I will disable them in a follow up commit. |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
All jobs completed with new changes: https://github.com/michdolan/OpenColorIO/actions/runs/85424974 |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
[Question] The current build image is the ASWF 2019 one, and you plan to transition the build system to the 2020 one. However, I think that the build system must support the latest VFX Platform recommandation plus 1 or 2 older ones. [Comment] The new build description is better. It would be nice to have the compiler version if that's possible. |
When I add CY2020 my plan was to keep CY2019 as well. We could add CY2018, but in terms of OCIO dependencies there is not a difference (compilers have not changed between the three years). Even between 2019/2020 the major difference for us is only the Python version. [edit] OpenEXR version has also changed. I could re-add compiler version, but it will need to be hard-coded since there is no way to inspect it from the docker container. As a counter argument, if you really want to know the specific compiler version, the job is broken up into really granular steps and within the top lines of the "Configure" step you can see the exact compiler version reported by CMake. But I can add it back in. |
Also, I just remembered why I was using C++14. It's because VFX ref platform mandates it since CY2018. We can keep with C++11, but just mentioning it. |
Right, and CY2019 & CY2018 are for OCIOv1.
So, one build per compiler with C++14 is then needed.
If that's not easy, then forget. |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
GH actions test of new changes: |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Few comments using the latest CI build:
|
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Most recent GH Actions build: |
The most recent commit responds to all comments except resolving the Python 3 install in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @michdolan
Signed-off-by: Michael Dolan <michdolan@gmail.com>
This adds GH Actions CI as a replacement for AZP, per the ASWF decision to switch, and in preparation for adding GPU CI support.
Some notes to help in reviewing the changes:
include
feature (designed for tacking additional variables onto specific matrix builds) to define each of the index builds independently. The result is fewer builds, but still good representation of OCIO build options.ci-ocio:2020
image is added to theaswf-docker
project. I will submit issues/PRs there for needed changes and patch our workflow in later PR(s).Signed-off-by: Michael Dolan michdolan@gmail.com