Refactor of metadata printing and Exif read/write #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Maker notes" are extra camera manufacturer-specific metadata stored as opaque blobs inside Exif records. The manufacturers don't seem to publish the specs for these blobs, but they have been reverse engineered and with some hunting you can find tinkerer-prouced documentation (at a range of levels of completeness or correctness). With this patch, we do a substantial refactor of exif.cpp (and a bit of work in formatspec, rawinput, and other places) to incorporate full awareness of maker notes into our metadata processing. At this stage, we only read Canon makernotes, and quite incompletely. But we get a lot more of the metadata than we used to (previously we just ignored any makernotes we found), and the structure is now sound for adding more complete support for this and other cameras. This will be an ongoing project to support more cameras, but the foundation is now set for this work.
|
Fixes #1739 (at least, it's a start). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Maker notes" are extra camera manufacturer-specific metadata stored as
opaque blobs inside Exif records. The manufacturers don't seem to
publish the specs for these blobs, but they have been reverse engineered
and with some hunting you can find tinkerer-prouced documentation (at a
range of levels of completeness or correctness).
With this patch, we do a substantial refactor of exif.cpp to incorporate
full awareness of maker notes into our metadata processing. At this
stage, we only read Canon makernotes, and quite incompletely. But we get
a lot more of the metadata than we used to (previously we just ignored
any makernotes we found), and the structure is now sound for adding more
complete support for this and other cameras. It involved a substantial
refactor of exif.cpp, as well as some other assorted tweaks.
This will be an ongoing project to support more cameras, but the foundation
is now set for this work.