More build time reduction #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break the longest-compiling file, imagebufalgo_mathops.cpp, into imagebufalgo_addsub.cpp, imagebufalgo_muldiv.cpp, imagebufalgo_mad.cpp, and a teensy bit of refactoring within those files to reduce compilation effort. Also changed the src/libOpenImageIO/CMakeLists.txt to list the most expensive files first, in the hope that if it does that first, it can load balance easier by having lots of inexpensive files to work on with the other cores. The net result is that it saves another 15 seconds of wall clock time when building with 24 cores, down from about 2 minutes (so around another 12%).
GerHobbelt
pushed a commit
to GerHobbelt/oiio
that referenced
this pull request
Dec 10, 2024
* Fix documentation build on Doxygen 1.9.7 Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove doxygen group names Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove remaining doxygen group Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com>
GerHobbelt
pushed a commit
to GerHobbelt/oiio
that referenced
this pull request
Dec 10, 2024
…Foundation#1812) * Fix documentation build (AcademySoftwareFoundation#1809) * Fix documentation build on Doxygen 1.9.7 Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove doxygen group names Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove remaining doxygen group Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com> Signed-off-by: Brooke <beg9562@rit.edu> * Updated documentation as 3D LUTs can now be inverted Signed-off-by: Brooke <brkglvn@gmail.com> Signed-off-by: Brooke <beg9562@rit.edu> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com> Signed-off-by: Brooke <beg9562@rit.edu> Signed-off-by: Brooke <brkglvn@gmail.com> Co-authored-by: Rémi Achard <remiachard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break the longest-compiling file, imagebufalgo_mathops.cpp, into
imagebufalgo_addsub.cpp, imagebufalgo_muldiv.cpp, imagebufalgo_mad.cpp,
and a teensy bit of refactoring within those files to reduce compilation
effort.
Also changed the src/libOpenImageIO/CMakeLists.txt to list the most
expensive files first, in the hope that if it does that first, it can
load balance easier by having lots of inexpensive files to work on with
the other cores.
The net result is that it saves another 15 seconds of wall clock time
when building with 24 cores, down from about 2 minutes (so around another
12%).