Zfile write safety #3670
Merged
Zfile write safety #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing a zfile, anything that causes open() to fail will leave m_tilebuffer at 0 size. Subsequent calls to write_tiles, and also to close (which cleans up unwritten parts of the buffer at the end) did not check for this condition and would access out of bounds memory. While I was in there, I converted the zfile.cpp error messages to the new formatting convention.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 15, 2022
When writing a zfile, anything that causes open() to fail will leave m_tilebuffer at 0 size. Subsequent calls to write_tiles, and also to close (which cleans up unwritten parts of the buffer at the end) did not check for this condition and would access out of bounds memory. While I was in there, I converted the zfile.cpp error messages to the new formatting convention. Fixes TALOS-2022-1657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a zfile, anything that causes open() to fail will leave m_tilebuffer at 0 size. Subsequent calls to write_tiles, and also to close (which cleans up unwritten parts of the buffer at the end) did not check for this condition and would access out of bounds memory.
While I was in there, I converted the zfile.cpp error messages to the new formatting convention.