-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt6 feature branch - Various fix for all platforms and VFX 2024 CI (Except Windows) #618
Merged
cedrik-fuoco-adsk
merged 38 commits into
AcademySoftwareFoundation:feature/qt6
from
cedrik-fuoco-adsk:qt6-ci-and-linux-mac-fix
Nov 11, 2024
Merged
Qt6 feature branch - Various fix for all platforms and VFX 2024 CI (Except Windows) #618
cedrik-fuoco-adsk
merged 38 commits into
AcademySoftwareFoundation:feature/qt6
from
cedrik-fuoco-adsk:qt6-ci-and-linux-mac-fix
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… that the context is initialized Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… Will try to re-implement those later. THIS IS NOT TESTED YET. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… mu binding Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…NOT RECOMMENDED TO DO IN A NEW SCRIPT Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
November 8, 2024 14:42
bernie-laberge
approved these changes
Nov 8, 2024
eloisebrosseau
approved these changes
Nov 8, 2024
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
force-pushed
the
qt6-ci-and-linux-mac-fix
branch
2 times, most recently
from
November 8, 2024 19:38
3eb8b2b
to
2680a6a
Compare
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
force-pushed
the
qt6-ci-and-linux-mac-fix
branch
from
November 8, 2024 19:47
8ea2250
to
154d71a
Compare
cedrik-fuoco-adsk
merged commit Nov 11, 2024
0cb14d8
into
AcademySoftwareFoundation:feature/qt6
20 checks passed
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618) (Except Windows) Here's are the changes: - Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet) - Code changes to fix issues on Windows - Code changes to fix issues on MacOS - Added OpenSSL 3 for VFX2024 - Added some logic to all `.wrapper` to detect which VFX platform is active (using Python version) and then use the right OpenSSL version. - FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too. **There are a lot of reformatting because of the pre-commit hook. Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.** - [x] Rocky linux 8/9 - [x] MacOS - [ ] Windows (partial, can compile with my windows, but not in CI because of pyside6 issue) --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618) (Except Windows) Here's are the changes: - Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet) - Code changes to fix issues on Windows - Code changes to fix issues on MacOS - Added OpenSSL 3 for VFX2024 - Added some logic to all `.wrapper` to detect which VFX platform is active (using Python version) and then use the right OpenSSL version. - FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too. **There are a lot of reformatting because of the pre-commit hook. Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.** - [x] Rocky linux 8/9 - [x] MacOS - [ ] Windows (partial, can compile with my windows, but not in CI because of pyside6 issue) --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618) (Except Windows) Here's are the changes: - Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet) - Code changes to fix issues on Windows - Code changes to fix issues on MacOS - Added OpenSSL 3 for VFX2024 - Added some logic to all `.wrapper` to detect which VFX platform is active (using Python version) and then use the right OpenSSL version. - FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too. **There are a lot of reformatting because of the pre-commit hook. Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.** - [x] Rocky linux 8/9 - [x] MacOS - [ ] Windows (partial, can compile with my windows, but not in CI because of pyside6 issue) --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618) (Except Windows) Here's are the changes: - Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet) - Code changes to fix issues on Windows - Code changes to fix issues on MacOS - Added OpenSSL 3 for VFX2024 - Added some logic to all `.wrapper` to detect which VFX platform is active (using Python version) and then use the right OpenSSL version. - FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too. **There are a lot of reformatting because of the pre-commit hook. Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.** - [x] Rocky linux 8/9 - [x] MacOS - [ ] Windows (partial, can compile with my windows, but not in CI because of pyside6 issue) --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618) (Except Windows) Here's are the changes: - Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet) - Code changes to fix issues on Windows - Code changes to fix issues on MacOS - Added OpenSSL 3 for VFX2024 - Added some logic to all `.wrapper` to detect which VFX platform is active (using Python version) and then use the right OpenSSL version. - FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too. **There are a lot of reformatting because of the pre-commit hook. Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.** - [x] Rocky linux 8/9 - [x] MacOS - [ ] Windows (partial, can compile with my windows, but not in CI because of pyside6 issue) --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
added a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618) (Except Windows) Here's are the changes: - Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet) - Code changes to fix issues on Windows - Code changes to fix issues on MacOS - Added OpenSSL 3 for VFX2024 - Added some logic to all `.wrapper` to detect which VFX platform is active (using Python version) and then use the right OpenSSL version. - FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too. **There are a lot of reformatting because of the pre-commit hook. Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.** - [x] Rocky linux 8/9 - [x] MacOS - [ ] Windows (partial, can compile with my windows, but not in CI because of pyside6 issue) --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt6 feature branch - Various fix for all platforms and VFX 2024 CI (Except Windows)
Linked issues
#366
Summarize your change.
Here's are the changes:
.wrapper
to detect which VFX platform is active (using Python version) and then use the right OpenSSL version.There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.
Describe what you have tested and on which operating system.