Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 feature branch - Various fix for all platforms and VFX 2024 CI (Except Windows) #618

Conversation

cedrik-fuoco-adsk
Copy link
Contributor

@cedrik-fuoco-adsk cedrik-fuoco-adsk commented Nov 8, 2024

Qt6 feature branch - Various fix for all platforms and VFX 2024 CI (Except Windows)

Linked issues

#366

Summarize your change.

Here's are the changes:

  • Added VFX 2024 CI (except for Windows) without ci-openrv from aswf-docker for now (Linux only, not tested yet)
  • Code changes to fix issues on Windows
  • Code changes to fix issues on MacOS
  • Added OpenSSL 3 for VFX2024
  • Added some logic to all .wrapper to detect which VFX platform is active (using Python version) and then use the right OpenSSL version.
  • FIx issue with Python not finding Tkinter on MacOS. The issue was with VFX2024, but the fix make sense for VFX2023 too.

There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with PySide6 in the CI.

Describe what you have tested and on which operating system.

  • Rocky linux 8/9
  • MacOS
  • Windows (partial, can compile with my windows, but not in CI because of pyside6 issue)

cedrik-fuoco-adsk and others added 30 commits October 21, 2024 15:47
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… that the context is initialized

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… Will try to re-implement those later. THIS IS NOT TESTED YET.

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… mu binding

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…NOT RECOMMENDED TO DO IN A NEW SCRIPT

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
src/lib/app/RvCommon/RvApplication.cpp Outdated Show resolved Hide resolved
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
@cedrik-fuoco-adsk cedrik-fuoco-adsk force-pushed the qt6-ci-and-linux-mac-fix branch 2 times, most recently from 3eb8b2b to 2680a6a Compare November 8, 2024 19:38
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
@cedrik-fuoco-adsk cedrik-fuoco-adsk merged commit 0cb14d8 into AcademySoftwareFoundation:feature/qt6 Nov 11, 2024
20 checks passed
cedrik-fuoco-adsk added a commit to cedrik-fuoco-adsk/OpenRV that referenced this pull request Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618)

(Except Windows)

Here's are the changes:

- Added VFX 2024 CI (except for Windows) without ci-openrv from
aswf-docker for now (Linux only, not tested yet)
- Code changes to fix issues on Windows
- Code changes to fix issues on MacOS
- Added OpenSSL 3 for VFX2024
- Added some logic to all `.wrapper` to detect which VFX platform is
active (using Python version) and then use the right OpenSSL version.
- FIx issue with Python not finding Tkinter on MacOS. The issue was with
VFX2024, but the fix make sense for VFX2023 too.

**There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with
PySide6 in the CI.**

- [x] Rocky linux 8/9
- [x] MacOS
- [ ] Windows (partial, can compile with my windows, but not in CI
because of pyside6 issue)

---------

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk added a commit to cedrik-fuoco-adsk/OpenRV that referenced this pull request Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618)

(Except Windows)

Here's are the changes:

- Added VFX 2024 CI (except for Windows) without ci-openrv from
aswf-docker for now (Linux only, not tested yet)
- Code changes to fix issues on Windows
- Code changes to fix issues on MacOS
- Added OpenSSL 3 for VFX2024
- Added some logic to all `.wrapper` to detect which VFX platform is
active (using Python version) and then use the right OpenSSL version.
- FIx issue with Python not finding Tkinter on MacOS. The issue was with
VFX2024, but the fix make sense for VFX2023 too.

**There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with
PySide6 in the CI.**

- [x] Rocky linux 8/9
- [x] MacOS
- [ ] Windows (partial, can compile with my windows, but not in CI
because of pyside6 issue)

---------

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk added a commit to cedrik-fuoco-adsk/OpenRV that referenced this pull request Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618)

(Except Windows)

Here's are the changes:

- Added VFX 2024 CI (except for Windows) without ci-openrv from
aswf-docker for now (Linux only, not tested yet)
- Code changes to fix issues on Windows
- Code changes to fix issues on MacOS
- Added OpenSSL 3 for VFX2024
- Added some logic to all `.wrapper` to detect which VFX platform is
active (using Python version) and then use the right OpenSSL version.
- FIx issue with Python not finding Tkinter on MacOS. The issue was with
VFX2024, but the fix make sense for VFX2023 too.

**There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with
PySide6 in the CI.**

- [x] Rocky linux 8/9
- [x] MacOS
- [ ] Windows (partial, can compile with my windows, but not in CI
because of pyside6 issue)

---------

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk added a commit to cedrik-fuoco-adsk/OpenRV that referenced this pull request Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618)

(Except Windows)

Here's are the changes:

- Added VFX 2024 CI (except for Windows) without ci-openrv from
aswf-docker for now (Linux only, not tested yet)
- Code changes to fix issues on Windows
- Code changes to fix issues on MacOS
- Added OpenSSL 3 for VFX2024
- Added some logic to all `.wrapper` to detect which VFX platform is
active (using Python version) and then use the right OpenSSL version.
- FIx issue with Python not finding Tkinter on MacOS. The issue was with
VFX2024, but the fix make sense for VFX2023 too.

**There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with
PySide6 in the CI.**

- [x] Rocky linux 8/9
- [x] MacOS
- [ ] Windows (partial, can compile with my windows, but not in CI
because of pyside6 issue)

---------

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk added a commit to cedrik-fuoco-adsk/OpenRV that referenced this pull request Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618)

(Except Windows)

Here's are the changes:

- Added VFX 2024 CI (except for Windows) without ci-openrv from
aswf-docker for now (Linux only, not tested yet)
- Code changes to fix issues on Windows
- Code changes to fix issues on MacOS
- Added OpenSSL 3 for VFX2024
- Added some logic to all `.wrapper` to detect which VFX platform is
active (using Python version) and then use the right OpenSSL version.
- FIx issue with Python not finding Tkinter on MacOS. The issue was with
VFX2024, but the fix make sense for VFX2023 too.

**There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with
PySide6 in the CI.**

- [x] Rocky linux 8/9
- [x] MacOS
- [ ] Windows (partial, can compile with my windows, but not in CI
because of pyside6 issue)

---------

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk added a commit to cedrik-fuoco-adsk/OpenRV that referenced this pull request Nov 28, 2024
…xcept Windows) (AcademySoftwareFoundation#618)

(Except Windows)

Here's are the changes:

- Added VFX 2024 CI (except for Windows) without ci-openrv from
aswf-docker for now (Linux only, not tested yet)
- Code changes to fix issues on Windows
- Code changes to fix issues on MacOS
- Added OpenSSL 3 for VFX2024
- Added some logic to all `.wrapper` to detect which VFX platform is
active (using Python version) and then use the right OpenSSL version.
- FIx issue with Python not finding Tkinter on MacOS. The issue was with
VFX2024, but the fix make sense for VFX2023 too.

**There are a lot of reformatting because of the pre-commit hook.
Windows is not included in the VFX 2024 CI because of issues with
PySide6 in the CI.**

- [x] Rocky linux 8/9
- [x] MacOS
- [ ] Windows (partial, can compile with my windows, but not in CI
because of pyside6 issue)

---------

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants