Use single shared clang-cpp library starting with LLVM 9 #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 9.0 LLVM defaults to building a single clang-cpp library for non-developer builds. As this is just the default, and some distributions enable it only with LLVM 10 (e.g. Fedora), make the clang-cpp search dependent on the build mode.
lgritz
approved these changes
May 13, 2020
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
May 14, 2020
…wareFoundation#1171) Since 9.0 LLVM defaults to building a single clang-cpp library for non-developer builds. As this is just the default, and some distributions enable it only with LLVM 10 (e.g. Fedora), make the clang-cpp search dependent on the build mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 9.0 LLVM defaults to building a single clang-cpp library for
non-developer builds.
As this is just the default, and some distributions enable it only with
LLVM 10 (e.g. Fedora), make the clang-cpp search dependent on the build
mode.
Compile tested with openSUSE Tumbleweed (LLVM 10) and Leap 15.2 (LLVM 7).
For some background, see https://fedoraproject.org/wiki/Changes/Stop-Shipping-Individual-Component-Libraries-In-clang-lib-Package and https://llvm.org/docs/CMake.html, option "BUILD_SHARED_LIBS".
Fixes the clang-cpp isssue mentioned in #1155