Fix memory leak in ASTvariable_declaration #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
force-pushed
the
lg-astleak
branch
3 times, most recently
from
4398e8c to
4b1114f
Compare
|
This look ok? |
fpsunflower
approved these changes
Sep 8, 2022
|
If it puts it into the symbol table (which it does if it's not metadata), this pointer is non-owning and the symbol table itself is responsible for deleting it. But for metadata, this is the only pointer to it. Let me take another look at this, maybe there is a more clear way to organize it to not be so confusing. |
Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
@fpsunflower I pushed an update. Do you think this makes the logic clearer? |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 6, 2022
…#1576) * Fix memory leak in ASTvariable_declaration Signed-off-by: Larry Gritz <lg@larrygritz.com>
chellmuth
pushed a commit
to chellmuth/OpenShadingLanguage
that referenced
this pull request
Sep 6, 2024
* Bug fix: assigning init-op param its default value as instance got lost (AcademySoftwareFoundation#1578) * Fix oslc memory leak in ASTvariable_declaration (AcademySoftwareFoundation#1576) See merge request spi/dev/3rd-party/osl-feedstock!32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.