Allow shader params (arrays/structs) empty brace initialization lists #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe worth adding a test for the |
lgritz
force-pushed
the
lg-emptyarrayparams
branch
from
d595dd8 to
d78df9a
Compare
|
Added test. It worked! |
lgritz
changed the title
|
LGTM! |
|
Did this fall through the cracks? Or was there an issue remaining? |
|
Yes, I think it just fell through the cracks. Will rebase and re-test and if all is well, will merge tomorrow. |
type myarray[] = {},
mystruct S = {}
Un-lengthed arrays, if they aren't connected or given a concrete
instance value, still default to length 1 (we don't allow 0-length
arrays, that's a whole other can of worms), but this is now treated as
equivalent to `= { default_value }` (0 for int or float, "" for string).
And it works for structs, too, just means to initialize all the elements
to is obvious (0, "") default values.
It's syntactic sugar, but it removes some clutter for people who want to
have shader parameters that are arrays of undetermined length (and thus
are probably expected to have a runtime-assigned instance value or be
conntected to an output of an earlier layer within the shader group),
removes the requirement for spelling out an initializing value that
won't be used anyway.
lgritz
force-pushed
the
lg-emptyarrayparams
branch
from
d78df9a to
f2969f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still gets length 1 (we don't allow 0-length arrays, that's a whole
other can of worms), but this is now treated as equivalent to
= { default_value }(0 for int or float, "" for string).It's syntactic sugar, but it removes some clutter for people who want to
have shader parameters that are arrays of undetermined length (and thus are
probably expected to have a runtime-assigned instance value or be
conntected to an output of an earlier layer within the shader group),
removes the requirement for spelling out an initializing value that
won't be used anyway.