Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the remains of "contrib" #1583

Merged

Conversation

apetrynet
Copy link
Contributor

As part of the reorganization effort listed in #1386 this PR removes the "contrib" directory tree and all references to the contrib adapters.
With exception of some of the documentation, all references to contrib should be removed.

make test passes locally

…b adapters.

Plugin system, setup and auto doc scripts no longer rely on contrib files.
Also removed some entries on other adapters left behind in the adapters.md file.

Signed-off-by: apetrynet <flehnerheener@gmail.com>
@apetrynet apetrynet requested a review from ssteinbach April 15, 2023 12:05
Signed-off-by: apetrynet <flehnerheener@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1583 (65aa594) into extract_adapters (b9581f5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           extract_adapters    #1583      +/-   ##
====================================================
- Coverage             74.64%   74.61%   -0.03%     
====================================================
  Files                   176      175       -1     
  Lines                 11997    11977      -20     
  Branches               2733     2732       -1     
====================================================
- Hits                   8955     8937      -18     
+ Misses                 1293     1292       -1     
+ Partials               1749     1748       -1     
Flag Coverage Δ
py-unittests 74.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...timelineio/console/autogen_plugin_documentation.py 65.21% <ø> (-2.58%) ⬇️
...-opentimelineio/opentimelineio/plugins/manifest.py 92.95% <ø> (+1.45%) ⬆️
tests/test_plugin_detection.py 91.46% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9581f5...65aa594. Read the comment docs.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @apetrynet

@apetrynet apetrynet merged commit 6ac5e90 into AcademySoftwareFoundation:extract_adapters May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants