Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped upload-artifact action from v3 to v4 #1827

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

reinecke
Copy link
Collaborator

@reinecke reinecke commented Jan 30, 2025

Supersedes #1740

Bump upload-artifact github action to v4 in line with deprecation.

The V4 update no longer supports implicit merge of matrixed build products into a single uploaded artifact (in v3 all wheel platform/python version variants were implicitly merged into a wheels artifact). This update makes a separate artifact for each matrix variant ant then merges them on download when creating a release to push to pypi.

@github-actions github-actions bot added the ci label Jan 30, 2025
Signed-off-by: Eric Reinecke <ereinecke@netflix.com>
@reinecke reinecke force-pushed the bump-upload-artifact-to-v4 branch from 0d1ab0b to a58efc3 Compare January 30, 2025 18:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (c0e97b0) to head (9c3cd99).
Report is 35 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
+ Coverage   84.11%   84.75%   +0.63%     
==========================================
  Files         198      176      -22     
  Lines       22241    12711    -9530     
  Branches     4687     1181    -3506     
==========================================
- Hits        18709    10773    -7936     
+ Misses       2610     1760     -850     
+ Partials      922      178     -744     
Flag Coverage Δ
py-unittests 84.75% <ø> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 129 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2985df...9c3cd99. Read the comment docs.

te upload artifact

Signed-off-by: Eric Reinecke <ereinecke@netflix.com>
… deprecated implicit merge behavior available in v3 upload artifact. Updated pypi publish to match new artifact name pattern

Signed-off-by: Eric Reinecke <ereinecke@netflix.com>
@reinecke reinecke force-pushed the bump-upload-artifact-to-v4 branch from 65d2411 to c57e115 Compare January 30, 2025 19:46
Signed-off-by: Eric Reinecke <ereinecke@netflix.com>
…rtifact names

Signed-off-by: Eric Reinecke <ereinecke@netflix.com>
darbyjohnston added a commit to darbyjohnston/OpenTimelineIO that referenced this pull request Jan 30, 2025
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants