-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINGW : bad use of __cpuid() #1445
Comments
No problems w/ MinGW GCC/Clang when not cross-compiling (e.g. using MSYS2), so restricting to |
Does it work w/ the |
I don't have Microsoft Windows so I can't check non-cross-compiling. Good to know that this patch may be bogus, even though it works for me. I haven't tried |
Perhaps the real/better fix is to remove/change
This is what I found in the MinGW shipped intrin.h:
This has popped up before IIRC - gotta keep in mind Windows as a platforms is not just MSVC... ;) There might be other places where |
at least in the OpenEXRCore library, _MSC_VER should only be used to truly detect msvc, not the win32 api vs. not - although at this level of builtin functions vs. not, this may fall over occasionally. I believe I had actually addressed this already in #1467 (noticing that disconnect). Once that is merged, do let us know if there are other related issues. Thanks for noticing this |
On 10/07/2023 03:28, Cary Phillips wrote:
@claudeha <https://github.com/claudeha>, could you confirm whether
this is still and issue with your build configuration on the |main|
branch? Hopefully, #1467
<#1467> fixes it.
The library seems to build ok now, thanks. But there is still an issue
with `src/test/OpenEXRCoreTest`:
```
$ cd openexr
$ rm -rf build/
$ mkdir build
$ cd build/
$ PKG_CONFIG_PATH=${HOME}/tmp/windows/lib/pkgconfig cmake
-DBUILD_SHARED_LIBS=OFF
-DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-mingw.cmake
-DCMAKE_CXX_FLAGS="-I${HOME}/tmp/windows"
-DCMAKE_EXE_LINKER_FLAGS="-L${HOME}/tmp/windows/lib"
-DCMAKE_INSTALL_PREFIX="${HOME}/tmp/windows" ..
...
$ make -k
...
$ make -k
...
[ 63%] Building CXX object
src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/base_units.cpp.obj
In file included from /usr/share/mingw-w64/include/intrin.h:41,
from /home/claude/tmp/windows/include/Imath/half.h:183,
from
/home/claude/opt/windows/posix/x86_64/src/openexr/src/test/OpenEXRCoreTest/../../lib/OpenEXRCore/internal_coding.h:24,
from
/home/claude/opt/windows/posix/x86_64/src/openexr/src/test/OpenEXRCoreTest/base_units.cpp:24:
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2013:42: error:
macro "__cpuid" requires 5 arguments, but only 2 given
2013 | void __cpuid(int CPUInfo[4], int InfoType);
| ^
In file included from
/home/claude/opt/windows/posix/x86_64/src/openexr/src/test/OpenEXRCoreTest/../../lib/OpenEXRCore/internal_cpuid.h:18,
from
/home/claude/opt/windows/posix/x86_64/src/openexr/src/test/OpenEXRCoreTest/base_units.cpp:23:
/usr/lib/gcc/x86_64-w64-mingw32/12-posix/include/cpuid.h:223: note:
macro "__cpuid" defined here
223 | #define __cpuid(level, a, b, c,
d) \
|
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2016:42: error:
macro "__cpuid" requires 5 arguments, but only 2 given
2016 | void __cpuid(int CPUInfo[4], int InfoType) {
| ^
/usr/lib/gcc/x86_64-w64-mingw32/12-posix/include/cpuid.h:223: note:
macro "__cpuid" defined here
223 | #define __cpuid(level, a, b, c,
d) \
|
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2013:6: error:
variable or field ‘__cpuid’ declared void
2013 | void __cpuid(int CPUInfo[4], int InfoType);
| ^~~~~~~
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2016:6: error:
variable or field ‘__cpuid’ declared void
2016 | void __cpuid(int CPUInfo[4], int InfoType) {
| ^~~~~~~
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2017:4: error:
expected primary-expression before ‘__asm__’
2017 | __asm__ __volatile__ (
| ^~~~~~~
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2017:4: error:
expected ‘}’ before ‘__asm__’
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2016:44: note: to
match this ‘{’
2016 | void __cpuid(int CPUInfo[4], int InfoType) {
| ^
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2280:1: error:
expected declaration before ‘}’ token
2280 | }
| ^
make[2]: ***
[src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/build.make:77:
src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/base_units.cpp.obj]
Error 1
make[2]: Target
'src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/build' not
remade because of errors.
...
```
Host is Debian Bookworm compiling with MINGW mingw-w64 10.0.0-3
(x86_64-w64-mingw32-g++ (GCC) 12-posix).
|
for me there is still an issue with the tests with
|
I notice this
It makes me wonder if you have a very old system installed half.h, and if using a new imath would fix the issue. |
On 21/08/2023 21:42, Nick Porcino wrote:
I notice this
|/home/claude/opt/windows/posix/x86_64/include/Imath/half.h |
It makes me wonder if you have a very old system installed half.h, and
if using a new imath would fix the issue.
I was using Imath 3.1.9 (I think this is the latest stable release?)
Can you try reconfiguring your build, using the
|OPENEXR_FORCE_INTERNAL_IMATH| flag?
adding
` -DOPENEXR_FORCE_INTERNAL_IMATH=on`
breaks detection of my system installed `libdeflate.h` (configured using
`-DCMAKE_CXX_FLAGS="-I${prefix}/include"`)
also adding `-DOPENEXR_FORCE_INTERNAL_DEFLATE=on` gives a similar
`__cpuid` error as before:
```
[ 74%] Building CXX object
src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/base_units.cpp.obj
In file included from /usr/share/mingw-w64/include/intrin.h:41,
from
/home/claude/opt/windows/posix/x86_64/src/openexr-3.2.0-rc/build/_deps/imath-src/src/Imath/half.h:183,
from
/home/claude/opt/windows/posix/x86_64/src/openexr-3.2.0-rc/src/test/OpenEXRCoreTest/../../lib/OpenEXRCore/internal_coding.h:24,
from
/home/claude/opt/windows/posix/x86_64/src/openexr-3.2.0-rc/src/test/OpenEXRCoreTest/base_units.cpp:24:
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2013:42: error:
macro "__cpuid" requires 5 arguments, but only 2 given
2013 | void __cpuid(int CPUInfo[4], int InfoType);
| ^
In file included from
/home/claude/opt/windows/posix/x86_64/src/openexr-3.2.0-rc/src/test/OpenEXRCoreTest/../../lib/OpenEXRCore/internal_cpuid.h:21,
from
/home/claude/opt/windows/posix/x86_64/src/openexr-3.2.0-rc/src/test/OpenEXRCoreTest/base_units.cpp:23:
/usr/lib/gcc/x86_64-w64-mingw32/12-posix/include/cpuid.h:223: note:
macro "__cpuid" defined here
223 | #define __cpuid(level, a, b, c,
d) \
|
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2016:42: error:
macro "__cpuid" requires 5 arguments, but only 2 given
2016 | void __cpuid(int CPUInfo[4], int InfoType) {
| ^
/usr/lib/gcc/x86_64-w64-mingw32/12-posix/include/cpuid.h:223: note:
macro "__cpuid" defined here
223 | #define __cpuid(level, a, b, c,
d) \
|
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2013:6: error:
variable or field ‘__cpuid’ declared void
2013 | void __cpuid(int CPUInfo[4], int InfoType);
| ^~~~~~~
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2016:6: error:
variable or field ‘__cpuid’ declared void
2016 | void __cpuid(int CPUInfo[4], int InfoType) {
| ^~~~~~~
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2017:4: error:
expected primary-expression before ‘__asm__’
2017 | __asm__ __volatile__ (
| ^~~~~~~
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2017:4: error:
expected ‘}’ before ‘__asm__’
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2016:44: note: to
match this ‘{’
2016 | void __cpuid(int CPUInfo[4], int InfoType) {
| ^
/usr/share/mingw-w64/include/psdk_inc/intrin-impl.h:2280:1: error:
expected declaration before ‘}’ token
2280 | }
| ^
make[2]: ***
[src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/build.make:77:
src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/base_units.cpp.obj]
Error 1
make[1]: *** [CMakeFiles/Makefile2:1914:
src/test/OpenEXRCoreTest/CMakeFiles/OpenEXRCoreTest.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
```
This problem earlier occured in the main code too, but it was fixed
there (but it seems not in the tests).
|
As noted in AcademySoftwareFoundation#1445, _MSC_VER should only be used to detect msvc, not for Windows. The _WIN32 check should be sufficient. The extra check for _MSC_VER fails when cross-compiling from Linux to Windows. Signed-off-by: Cary Phillips <cary@ilm.com>
As noted in #1445, _MSC_VER should only be used to detect msvc, not for Windows. The _WIN32 check should be sufficient. The extra check for _MSC_VER fails when cross-compiling from Linux to Windows. Signed-off-by: Cary Phillips <cary@ilm.com>
…ion#1528) As noted in AcademySoftwareFoundation#1445, _MSC_VER should only be used to detect msvc, not for Windows. The _WIN32 check should be sufficient. The extra check for _MSC_VER fails when cross-compiling from Linux to Windows. Signed-off-by: Cary Phillips <cary@ilm.com>
* Propagate OPENEXR_INSTALL_PKG_CONFIG to internal Imath (#1531) * Propagate OPENEXR_INSTALL_PKG_CONFIG to internal Imath If OpenEXR is installing a pkg-config file, then the internal Imath build (if there is one) should install it, too. Also, add an explicit release version variable to the .pc file. This is in preparation for the python wheel build to pick up the version settings from the pkg-config files. Signed-off-by: Cary Phillips <cary@ilm.com> * remove version= from OpenEXR.pc Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * Remove check for _MSC_VER in internal_cpuid.h (#1528) As noted in #1445, _MSC_VER should only be used to detect msvc, not for Windows. The _WIN32 check should be sufficient. The extra check for _MSC_VER fails when cross-compiling from Linux to Windows. Signed-off-by: Cary Phillips <cary@ilm.com> * Fix warnings in multipartExamples.cpp (#1533) * Fix warnings in multipartExamples.cpp Signed-off-by: Cary Phillips <cary@ilm.com> * fix indentation Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * Fix warnings from cross-compiling with x86_64-w64-mingw32-gcc-posix (#1534) * Fix compiler warnings from x86_64-w64-mingw32-g++-posix * MSVCRT doesn't recognize printf("%l") so PRIu64 doesn't work, it expects "%I64u". * Add to the cases that disable a strncpy warning Signed-off-by: Cary Phillips <cary@ilm.com> * %zu for size_t Signed-off-by: Cary Phillips <cary@ilm.com> * revert attempt to fix PRIu64 warnings Signed-off-by: Cary Phillips <cary@ilm.com> * revert blank line Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * Fix OPENEXR_VERSION_HEX (#1539) * Fix OPENEXR_VERSION_HEX * fix syntax error * remove unnecessary uint32_t cast * add validation test Signed-off-by: Cary Phillips <cary@ilm.com> * Add #if statement with OPENEXR_VERSION_HEX Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * OPENEXR_INSTALL_PKG_CONFIG is on by default, even on Windows (#1541) There seems to be no downside to generating the OpenEXR.pc file even on Windows, so for consistency, apply the setting to all platforms. Signed-off-by: Cary Phillips <cary@ilm.com> * Remove SPDX license identifier in LICENSE.md Signed-off-by: Cary Phillips <cary@ilm.com> * Python wheel setup gets version from OpenEXR.pc/Imath.pc (#1536) * Python wheel setup gets version from OpenEXR.pc/Imath.pc OpenEXR and Imath have indepdenent versions that may not match. The .pc files appear to be the simplest way to extract the versions and library suffixes. Running pkg-config itself doesn't work on Windows, hence the manual file parsing. Signed-off-by: Cary Phillips <cary@ilm.com> * = Signed-off-by: Cary Phillips <cary@ilm.com> * Remove -DOPENEXR_INSTALL_PKG_CONFIG=ON since it's now on by default Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * Default value for chromaticities attribute constructor in exrstdattr (#1540) Signed-off-by: Cary Phillips <cary@ilm.com> * Update openexr_deps.bzl (#1565) Signed-off-by: Vertexwahn <julian.amann@tum.de> * Bazel: Improve module (#1562) Signed-off-by: Vertexwahn <julian.amann@tum.de> * Set build-shared:OFF for Static build (#1557) Looks like this somehow we've been building shared when we meant to be building static. Signed-off-by: Cary Phillips <cary@ilm.com> * Omit OPENEXR_IMAGES_TAG from test image url if empty (#1560) This allows the url for the test images to reference a local file: cmake -DOPENEXR_IMAGES_REPO=file:///my/clone/of/openexr-images -DOPENEXR_IMAGES_TAG="" which avoids the remote downloading of the test images at cmake time. Also, mention the test images in the install docs. Signed-off-by: Cary Phillips <cary@ilm.com> * Clean up handling of libdeflate when linking static (#1561) * Set EXR_DEFLATE_LIB properly for static linking This leads OpenEXRCore/CMakeLists.txt to do: target_link_libraries(OpenEXRCore PUBLIC libdeflate) instead of: target_link_libraries(OpenEXRCore PUBLIC PkgConfig::deflate) which is not recognized. With a target link library of `PkgConfig::deflate`, the static build of the OpenEXR libraries builds successfully, but configuring an application against those static libraries fails, saying it can't find `PkgConfig::deflate`. Signed-off-by: Cary Phillips <cary@ilm.com> * Add -ldeflate to pkgconfig for static builds When static linking and referencing an external libdeflate (i.e. not fetching and building internally), OpenEXR.pc needs -ldeflate. This also adds a test for this condition to the CI's validation script. Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * Don't trigger ci/bazel/ossfuzz builds on pushes/PRs to src/wrappers (#1532) No need to rebuild/test OpenEXR on changes to the python wheels. Signed-off-by: Cary Phillips <cary@ilm.com> * Set minimal permissions for workflow python-wheels.yml (#1530) The exact same changes done on other workflows through the PR #1417 Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com> * Release notes for 3.2.1 Signed-off-by: Cary Phillips <cary@ilm.com> * Fix Imf/Iex/IlmThread namespaces in python bindings and website code (#1568) * Fix Imf/Iex/IlmThread namespaces in python bindings and website code Use OPENEXR_NAMESPACE, IEX_NAMESPACE, ILMTHREAD_NAMESPACE instead of Imf, Iex, IlmThread, to support custom settings. Signed-off-by: Cary Phillips <cary@ilm.com> * Use Iex:: namespace in example code instead of IEX_NAMESPACE Requires this in all.cpp: namespace Iex = IEX_NAMESPACE; Signed-off-by: Cary Phillips <cary@ilm.com> * use #define Iex Signed-off-by: Cary Phillips <cary@ilm.com> * remove explicit Iex namespace Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> * Bump version to 3.2.1 Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Cary Phillips <cary@ilm.com> Signed-off-by: Vertexwahn <julian.amann@tum.de> Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com> Co-authored-by: Vertexwahn <julian.amann@tum.de> Co-authored-by: Diogo Teles Sant'Anna <diogoteles@google.com>
When cross-compiling OpenEXR-3.1.8 from the release tarball for Windows from Debian Bookworm (current testing distribution) using
x86_64-w64-mingw32-g++ (GCC) 12-posix
, the build fails because__cpuid()
is called with 2 arguments instead of 5. This small patch seems to fix it:The text was updated successfully, but these errors were encountered: