Cleanup cmake thread detection #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old variables, prepare for glibc 2.34+ where pthread moves into libc to detect semaphores. Force enable C11 for core library to turn on atomics for older compilers Fix error messages Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
approved these changes
Sep 5, 2021
|
@kdtrd, when you merged this did you squash or rebase? Our policy is to squash, even if it's a single commit, because that rewrites the commit title to include the PR #, which is helpful downstream when merging into a branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old variables, prepare for glibc 2.34+ where pthread moves into
libc to detect semaphores.
Force enable C11 for core library to turn on atomics for older compilers
Fix error messages
Signed-off-by: Kimball Thurston kdt3rd@gmail.com