Fix range check in dwa compressor #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Porcino <meshula@hotmail.com>
kdt3rd
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Yes, these were added in haste after discovering that the individual size checks were not failing, but the summation of all the offsets caused a past the end access. I do think the logic here can be simplified over time, but was concerned with breaking compatibility, which I then proceeded to do :)
Your fix is fine here, thanks for the suggestion
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jul 25, 2023
Signed-off-by: Nick Porcino <meshula@hotmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
Jul 31, 2023
Signed-off-by: Nick Porcino <meshula@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out-dwaa.zip
I've attached out-dwaa.exr ~ note that I simply renamed it to .zip because github doesn't allow uploading of exr files into an issue. So just rename it back to exr.
anyway :)
The attached file fails to load in OpenEXRCore, because it's got some buffers that exactly line up at their ends, which causes the sanity checks to fail. Changing the comparisons to
<instead of<=allows the file to load, and I believe preserves the intent of the checks.Note that I pre-emptively switched all of the checks to
<even though changing only the first one is sufficient to load this particular test file. I'm wondering if someone could sanity check all the checks?