Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling for corrupt number of DC components #1484

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Jul 10, 2023

When the number of DC components has been incorrectly stored in the dwa subheader, this causes a cascade of errors, resulting in out of bounds access. Instead, track how many we've read and detect when we're out as soon as possible

Fixes OSS-Fuzz #59457

When the number of DC components has been incorrectly stored in the dwa
subheader, this causes a cascade of errors, resulting in out of bounds
access. Instead, track how many we've read and detect when we're out as
soon as possible

Fixes OSS-Fuzz #59457

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything need to be done with the previous patch I made where in the test, I replaced with <= with <? I'm unclear as to whether I was overly aggressive in that.

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit 54dd041 into AcademySoftwareFoundation:main Jul 23, 2023
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Jul 25, 2023
…dation#1484)

When the number of DC components has been incorrectly stored in the dwa
subheader, this causes a cascade of errors, resulting in out of bounds
access. Instead, track how many we've read and detect when we're out as
soon as possible

Fixes OSS-Fuzz #59457

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm pushed a commit that referenced this pull request Jul 31, 2023
When the number of DC components has been incorrectly stored in the dwa
subheader, this causes a cascade of errors, resulting in out of bounds
access. Instead, track how many we've read and detect when we're out as
soon as possible

Fixes OSS-Fuzz #59457

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants