change OpaqueAttribute's _typeName field to be std::string #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aqueAttribute, whose type name was stored as Array<char>. I changed the type to std::string. I suspect this simply dates to a time before std::string was commonly used. Also, it appears that nothing in the test suite validated opaque attributes, which hold values read from a file when the attribute type is not known. I added a test to validate the behavior, which also validates that the typeName() works when implemented with std::string instead of Array<char>. Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
Jul 9, 2019
| @@ -76,7 +74,7 @@ OpaqueAttribute::~OpaqueAttribute () | |||
| const char * | |||
| OpaqueAttribute::typeName () const | |||
| { | |||
| return _typeName; | |||
| return _typeName.c_str(); | |||
There was a problem hiding this comment.
Sadly this is unsafe, but the behavior is the same as before. It's interesting that Sonar doesn't spot it, as one would image returning c_str() is a smell the same strcpy is....
There was a problem hiding this comment.
I don't think so. strcpy() is a vulnerability because of the potential for buffer overflow, but SonarCloud does not regard c_str() as a vulnerability.
| private: | ||
|
|
||
| Array<char> _typeName; | ||
| std::string _typeName; | ||
| long _dataSize; | ||
| Array<char> _data; |
There was a problem hiding this comment.
This is another funny one, char is a signed value, and has a sizeof(1) and a bitsize of CHAR_BIT. I wonder if now is an opportunity to make _data an Array of std::uint8_t?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SonarCloud considers strcpy() a vulernability. strcpy() was used only in OpaqueAttribute, whose type name was stored as Array. I changed the type to std::string. I suspect this simply dates to a time before std::string was commonly used.
Also, it appears that nothing in the test suite validated opaque attributes, which hold values read from a file when the attribute type is not known. I added a test to validate the behavior, which also validates that the typeName() works when implemented with std::string instead of Array.
Signed-off-by: Cary Phillips cary@ilm.com