ImfAcesFile.cpp: Fix primary conversion edge case. #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the edge case when the file chromaticities.white != file adopted neutral. In such a scenario the adoptedNeutral file attr must be used as the display white point value passed into RGBtoXYZ() method since the adaption matrix (Bradform Transform) is computed using the adopted neutral as its input white point. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
cary-ilm
added
the
Needs Discussion
Since fileChr.white is 'fileNeutral' and acesChr.white is 'acesNeutral' always. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
JGoldstone
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the edge case when the file chromaticities.white != file adopted
neutral.
In such a scenario the adoptedNeutral file attr must be used as the
display white point value passed into RGBtoXYZ() method since
the adaption matrix (Bradform Transform) is computed using the adopted neutral as its
input white point.
Signed-off-by: Arkell Rasiah arasiah@pixsystem.com