Fix offchain workers and add tests #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrell-code
commented
Sep 13, 2021
ferrell-code
commented
Sep 13, 2021
ferrell-code
commented
Sep 13, 2021
|
Now there are unit tests so no one else can break it :) Edit: I believe these are the only two off-chain workers in our code base, I would add test to others but I think these are it |
xlc
reviewed
Sep 13, 2021
xlc
previously approved these changes
Sep 14, 2021
|
Don't merge this yet, key still doesn't work to continue iterator from where it left off, I will add to tests so it fails in that case, when I figure out how to fix it Edit: Okay is good on my end now, the iterator now correctly starts where it left off for when the raw key is stored in offchain storage |
ferrell-code
commented
Sep 14, 2021
xlc
approved these changes
Sep 14, 2021
xlc
pushed a commit
that referenced
this pull request
Sep 19, 2021
* fix offchain worker and add tests * offchain worker tests wip * finish cdp-engine test * test max iterations * remove dbg! * add auction manager tests * make None into DEFAULT_MAX_ITERATIONS * add test for when max iterations is none * key sets correctly for iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1405
Fixes auction-manager and cdp-engine offchain workers and adds tests