Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcm trap assets ed #1654

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Xcm trap assets ed #1654

merged 9 commits into from
Dec 1, 2021

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Nov 30, 2021 •
edited
Loading

closes #1653

  • integration test
    • relaychain to parachain
    • slibling to parachain
  • other runtime add AcalaDropAssets too
    • maybe refactor common code to common package?
  • the kusama_cross_chain_transfer.rs getting more large, should we seperate to different file?

@zqhxuyuan zqhxuyuan requested review from xlc and shaunxw November 30, 2021 09:17
xlc
xlc reviewed Nov 30, 2021
View reviewed changes
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
zqhxuyuan
zqhxuyuan commented Nov 30, 2021
View reviewed changes
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
@zqhxuyuan zqhxuyuan marked this pull request as ready for review December 1, 2021 02:29
xlc
xlc reviewed Dec 1, 2021
View reviewed changes
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
@zqhxuyuan zqhxuyuan merged commit 9a27cfd into master Dec 1, 2021
@zqhxuyuan zqhxuyuan deleted the xcm_trap_assets_ed branch December 1, 2021 06:26
syan095 pushed a commit that referenced this pull request Dec 1, 2021
Merge remote-tracking branch 'origin/master' into fix/xcm-fee-return
3b4d0bf 
* origin/master:
  Xcm trap assets ed (#1654)
  re-benchmarked the homa-lite module (#1638)

# Conflicts:
#	runtime/integration-tests/src/relaychain/kusama_cross_chain_transfer.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@shaunxw shaunxw Awaiting requested review from shaunxw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implements own DropAssets that deposit assets too low to treasury
2 participants
@zqhxuyuan @xlc