Pay fee for other account #2029
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
==============================
==============================
Continue to review full report at Codecov.
|
|
/bench runtime module module_transaction_payment |
|
Finished benchmark for branch: pay_for_other Benchmark: Benchmark Runtime Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules/transaction-payment/src/weights.rs --template=./templates/module-weight-template.hbs ResultsPallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
|
Finished benchmark for branch: pay_for_other Benchmark: Benchmark Runtime Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules/transaction-payment/src/weights.rs --template=./templates/module-weight-template.hbs ResultsPallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
|
/bench runtime module module_transaction_payment |
|
Finished benchmark for branch: pay_for_other Benchmark: Benchmark Runtime Module cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules/transaction-payment/src/weights.rs --template=./templates/module-weight-template.hbs ResultsDownloading crates ... error[E0407]: method Compiling module-nft v2.6.2 (/app/git/Acala/modules/nft) error[E0046]: not all trait items implemented, missing: Some errors have detailed explanations: E0046, E0053, E0407. |
|
need to merge master as evm is enabled on acala, so this feature can also applied on acala. |
|
/bench runtime karura module_transaction_payment |
|
Finished benchmark for branch: pay_for_other Benchmark: Benchmark Runtime Karura Module cargo run --profile production --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark pallet --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/ ResultsPallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
…untime-benchmarks --features=with-karura-runtime -- benchmark pallet --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/
|
/bench runtime acala module_transaction_payment |
|
Finished benchmark for branch: pay_for_other Benchmark: Benchmark Runtime Acala Module cargo run --profile production --color=never --bin=acala --features=runtime-benchmarks --features=with-acala-runtime -- benchmark pallet --chain=acala-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/ ResultsPallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
…untime-benchmarks --features=with-acala-runtime -- benchmark pallet --chain=acala-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/
|
/bench runtime mandala module_transaction_payment |
|
Finished benchmark for branch: pay_for_other Benchmark: Benchmark Runtime Mandala Module cargo run --profile production --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/ ResultsPallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
|
…untime-benchmarks --features=with-mandala-runtime -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/
…test-feature * origin/master: Return default value instead of error (#2152) remove EvmChainIdMigration (#2151) 2.6.4 (#2156) Aggregated Dex Improvement (#2140) Ability to transfer debits between loans (#2053) EVM rpc return proper error if api doesn't exists at block_id (#2144) Add claimDefaultEvmAddress (#2149) Fix estimate (#2142) update bootnodes Pay fee for other account (#2029) fix stable asset token (#2131) fix cdp-engine offchain worker (#2133) 2.6.3 (#2134) update version (#2126) support aggregated DEX (#2031) Enable evm for acala (#1907) Evm account precompile (#2124) Added no-metadata-docs and full-metadata-docs to runtimes (#2123) # Conflicts: # runtime/karura/Cargo.toml
relates to the last (two) step in: #1994
IntroduceSwitchFlagtrait to enable evm signature or not. so Mandala set flag to true while Karura and Acala can set flag to false if it's not ready to enable evm, and both those runtime all useAcalaUncheckedExtrinsic.PayerTxhook implements useConverttrait now, we can change to a better name, but that need introduce another trait.wait #1884 and #1907 asAcalaUncheckedExtrinsicis changed, we can also merged those PR and setSwitchFlagto false. and whenever it's ready, we can change it to true.Manual Test Guide:
Payer Sign(no submission)
Suppose Sender(Alice in this example) nonce is 4:
Get signature by "Decode" with "Signed Transaction" above
Sender submit extrinsic:
