-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charge storage fee to support non native asset #2045
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
- Coverage 86.45% 0 -86.46%
==========================================
Files 99 0 -99
Lines 21240 0 -21240
==========================================
- Hits 18362 0 -18362
+ Misses 2878 0 -2878 Continue to review full report at Codecov.
|
It is ok if Metamask can't handle it as that's basically the same behaviour of Ethereum. This however will be useful for polkadot.js extension user or dApp using EIP712 signature format. |
closes: #2039
change evm reserve_storage from
T::Currency::reserve_named()
toT::ChargeTransactionPayment::reserve_fee()
, and we can add our own fee strategy in transaction payment module'sreserve_fee()
. That is,reserve_fee
now can support none native token.Acala/modules/evm/src/lib.rs
Line 1609 in 7c16cec
we do not need to change
unreserve_storage
andcharge_storage
in evm, becausereserve_storage
happend before those two operation. That is,unreserve_storage
andcharge_storage
always have native token.If we have this feature, I think
bodhi.jsMetamask needs support this too, currently if an eth account not bind to substrate account, it have enough none-native token, but not enough native token, the transfer can't proceed